Native Android accessibility.

content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibility.java

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibility.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibility.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibility.java
new file mode 100644
index 0000000000000000000000000000000000000000..e3f8e318c098c8b6e3463ce9b0cfd8f67f2915ed
--- /dev/null
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibility.java
@@ -0,0 +1,60 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.content.browser.accessibility;
+
+import android.graphics.Rect;
+import org.chromium.base.CalledByNative;
+import org.chromium.base.JNINamespace;
+
+/**
+ * This object is never instantiated, it's just used to define the interface Java code
+ * can use to access a BrowserAccessibilityAndroid C++ class, plus static helper methods
+ * for use by the C++ class.
+ */
+@JNINamespace("content")
+public class BrowserAccessibility {

[David Trainor- moved to gerrit, 2013/06/04 20:27:18]

Add a private constructor if it can't be initialized.  Also generally we don't
expose the native*** method as public, but rather a Java one that delegates to
the native.  Ideally we could then write unit tests and mock the native
component out.

It might make more sense to make those native methods private, and have
something like:

populateAccessibilityNodeInfo(AccessibilityNodeInfo info, ContentViewCore core,
int nodePtr)?

[dmazzoni, 2013/06/07 20:23:16]

Private constructor added.

I understand about exposing not native methods as public, but I don't think it
makes sense here - this class is never instantiated and *only* exposes native
methods,
so the extra indirection doesn't really buy anything.

We could move something like populateAccessibilityNodeInfo here, but there are
several methods in BrowserAccessibilityManager.java that require calling some of
these methods. I think it's cleaner to just have all of the logic in
BrowserAccessibilityManager.java where you can trace it through all at once.
What do you think?

If you still feel strongly I can change it.

+    @CalledByNative
+    private static Rect createRect(int x, int y, int right, int bottom) {
+        return new Rect(x, y, right, bottom);
+    }
+
+    // Actions.
+    static native void nativeFocusJNI(int nativeBrowserAccessibilityAndroid);
+    static native void nativeClickJNI(int nativeBrowserAccessibilityAndroid);
+
+    // Accessors.
+    static native String nativeGetNameJNI(int nativeBrowserAccessibilityAndroid);
+    static native Object nativeGetAbsoluteRectJNI(int nativeBrowserAccessibilityAndroid);
+    static native Object nativeGetRectInParentJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsFocusableJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsFocusedJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsEditableTextJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeGetClickableJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetParentJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetChildCountJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetChildIdAtJNI(int nativeBrowserAccessibilityAndroid, int childIndex);
+    static native boolean nativeIsCheckableJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsCheckedJNI(int nativeBrowserAccessibilityAndroid);
+    static native String nativeGetClassNameJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsEnabledJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsPasswordJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsScrollableJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsSelectedJNI(int nativeBrowserAccessibilityAndroid);
+    static native boolean nativeIsVisibleJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetItemIndexJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetItemCountJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetScrollXJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetScrollYJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetMaxScrollXJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetMaxScrollYJNI(int nativeBrowserAccessibilityAndroid);
+    static native String nativeGetAriaLiveJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetSelectionStartJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetSelectionEndJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetEditableTextLengthJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetTextChangeFromIndexJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetTextChangeAddedCountJNI(int nativeBrowserAccessibilityAndroid);
+    static native int nativeGetTextChangeRemovedCountJNI(int nativeBrowserAccessibilityAndroid);
+    static native String nativeGetTextChangeBeforeTextJNI(int nativeBrowserAccessibilityAndroid);
+};