Native Android accessibility.

content/browser/renderer_host/render_view_host_impl.cc

Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 73dd8d9ed6f1568d34b403dae349b59764cb2260..e72fd40b3d0ad0c9838f2908efd3dd71bec3b375 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -1909,18 +1909,32 @@ void RenderViewHostImpl::OnAccessibilityNotifications(
     const AccessibilityHostMsg_NotificationParams& param = params[i];
     AccessibilityNotification src_type = param.notification_type;
 
-    if ((src_type == AccessibilityNotificationLayoutComplete ||
-         src_type == AccessibilityNotificationLoadComplete) &&
-        save_accessibility_tree_for_testing_) {
-      MakeAccessibilityNodeDataTree(param.nodes, &accessibility_tree_);
+    bool is_about_blank = false;
+    for (unsigned j = 0; j < param.nodes.size(); j++) {
+      std::map<AccessibilityNodeData::StringAttribute, string16>::const_iterator iter;

[David Trainor- moved to gerrit, 2013/06/04 20:27:18]

line too long.

[dmazzoni, 2013/06/07 20:23:16]

Done.

+      iter = param.nodes[j].string_attributes.find(
+          AccessibilityNodeData::ATTR_DOC_URL);
+      if (iter != param.nodes[j].string_attributes.end()) {
+        string16 doc_url = iter->second;
+        if (doc_url == ASCIIToUTF16("about:blank"))

[David Trainor- moved to gerrit, 2013/06/04 20:27:18]

I feel like about:blank a constant somewhere.  I don't remember the place
though.

[dmazzoni, 2013/06/07 20:23:16]

Done.

+          is_about_blank = true;

[David Trainor- moved to gerrit, 2013/06/04 20:27:18]

break here?  Could also just put the logic in here and break.  No need to save
the bool?

[dmazzoni, 2013/06/07 20:23:16]

We'd need to break out of one for loop and continue from the other, which I'm
not sure would be more readable.

+      }
     }
 
-    if (src_type == AccessibilityNotificationLayoutComplete) {
-      accessibility_layout_callback_.Run();
-    } else if (src_type == AccessibilityNotificationLoadComplete) {
-      accessibility_load_callback_.Run();
-    } else {
-      accessibility_other_callback_.Run();
+    if (!is_about_blank) {
+      if ((src_type == AccessibilityNotificationLayoutComplete ||
+           src_type == AccessibilityNotificationLoadComplete) &&
+          save_accessibility_tree_for_testing_) {
+        MakeAccessibilityNodeDataTree(param.nodes, &accessibility_tree_);
+      }
+
+      if (src_type == AccessibilityNotificationLayoutComplete) {
+        accessibility_layout_callback_.Run();
+      } else if (src_type == AccessibilityNotificationLoadComplete) {
+        accessibility_load_callback_.Run();
+      } else {
+        accessibility_other_callback_.Run();
+      }
     }
   }