Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 15741009: Native Android accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address most reviewer feedback Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java
index 0e6e3815609dba63a469920f6f9e928e3e7808dc..5ac4dde6ab19bab006828b5e24564370bbe342d5 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java
@@ -12,11 +12,13 @@ import android.graphics.Canvas;
import android.graphics.Rect;
import android.os.Build;
import android.util.AttributeSet;
+import android.util.Log;
benm (inactive) 2013/06/10 14:24:24 nit: not needed
dmazzoni 2013/06/18 20:22:35 Done.
import android.view.KeyEvent;
import android.view.MotionEvent;
import android.view.View;
import android.view.accessibility.AccessibilityEvent;
import android.view.accessibility.AccessibilityNodeInfo;
+import android.view.accessibility.AccessibilityNodeProvider;
import android.view.inputmethod.EditorInfo;
import android.view.inputmethod.InputConnection;
import android.widget.FrameLayout;
@@ -491,6 +493,14 @@ public class ContentView extends FrameLayout
return mContentViewCore.onGenericMotionEvent(event);
}
+ @Override
+ public boolean dispatchHoverEvent(MotionEvent event) {
benm (inactive) 2013/06/10 14:24:24 Can you add these two methods into android_webview
dmazzoni 2013/06/18 20:22:35 Done.
+ if (mContentViewCore.dispatchHoverEvent(event)) {
+ return true;
+ }
+ return super.dispatchHoverEvent(event);
+ }
+
/**
* Sets the current amount to offset incoming touch events by. This is used to handle content
* moving and not lining up properly with the android input system.
@@ -582,6 +592,15 @@ public class ContentView extends FrameLayout
}
@Override
+ public AccessibilityNodeProvider getAccessibilityNodeProvider() {
+ AccessibilityNodeProvider provider = mContentViewCore.getAccessibilityNodeProvider();
+ if (provider != null)
+ return provider;
+ else
+ return super.getAccessibilityNodeProvider();
+ }
+
+ @Override
public void onInitializeAccessibilityNodeInfo(AccessibilityNodeInfo info) {
super.onInitializeAccessibilityNodeInfo(info);
mContentViewCore.onInitializeAccessibilityNodeInfo(info);

Powered by Google App Engine
This is Rietveld 408576698