runtime/vm/flow_graph_compiler_ia32.cc - Issue 15741002: Use a uniform way to emit code for all instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 15741002: Use a uniform way to emit code for all instructions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index aa731d9be7c952282239c9343081f5773080c1d5..730e5e1ec9d4067d1876e50bb2a57db17860364e 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -729,12 +729,7 @@ void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) {

AddCurrentDescriptor(PcDescriptors::kDeopt,

assert->deopt_id(),

assert->token_pos());

- } else if (instr->IsGuardField()) {

- GuardFieldInstr* guard = instr->AsGuardField();

- AddCurrentDescriptor(PcDescriptors::kDeopt,

- guard->deopt_id(),

- Scanner::kDummyTokenIndex);

- } else if (instr->CanBeDeoptimizationTarget()) {

+ } else if (instr->CanBeDeoptimizationTarget() || instr->IsGuardField()) {

AddCurrentDescriptor(PcDescriptors::kDeopt,

instr->deopt_id(),

Scanner::kDummyTokenIndex);

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | runtime/vm/intermediate_language.h » ('J')