Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 15741002: Use a uniform way to emit code for all instructions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 6569c5259f23b56c4681244fa9fb67cd78ac8fba..399c31b6c8ccfb4610834687e4808839d81f76fe 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -3783,8 +3783,11 @@ void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
LocationSummary* BranchInstr::MakeLocationSummary() const {
- UNREACHABLE();
- return NULL;
+ LocationSummary* summary = comparison()->locs();
+ // Share the location summary with the comparison. Branches don't produce
+ // a result.
+ summary->set_out(Location::NoLocation());
+ return summary;
}
@@ -4262,14 +4265,6 @@ LocationSummary* GotoInstr::MakeLocationSummary() const {
void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- if (!compiler->is_optimizing()) {
- // Add deoptimization descriptor for deoptimizing instructions that may
- // be inserted before this instruction.
- compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
- GetDeoptId(),
- 0); // No token position.
- }
-
if (HasParallelMove()) {
compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
}

Powered by Google App Engine
This is Rietveld 408576698