Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1574063005: [wasm] Fix double to int conversions. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix double to int conversions. R=ahaas@chromium.org LOG=Y BUG=chromium:576560 Committed: https://crrev.com/ed6fea15a9f025c4e928878822cfe7c5ee28d081 Cr-Commit-Position: refs/heads/master@{#33239}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/wasm/asm-wasm-builder.cc View 2 chunks +3 lines, -6 lines 1 comment Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
4 years, 11 months ago (2016-01-12 13:26:09 UTC) #1
ahaas
lgtm https://codereview.chromium.org/1574063005/diff/1/src/wasm/asm-wasm-builder.cc File src/wasm/asm-wasm-builder.cc (right): https://codereview.chromium.org/1574063005/diff/1/src/wasm/asm-wasm-builder.cc#newcode625 src/wasm/asm-wasm-builder.cc:625: return (TypeOf(expr->left()) == kAstI32) ? kAsIs : kToInt; ...
4 years, 11 months ago (2016-01-12 13:35:10 UTC) #2
titzer
On 2016/01/12 13:35:10, ahaas wrote: > lgtm > > https://codereview.chromium.org/1574063005/diff/1/src/wasm/asm-wasm-builder.cc > File src/wasm/asm-wasm-builder.cc (right): > ...
4 years, 11 months ago (2016-01-12 13:39:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574063005/1
4 years, 11 months ago (2016-01-12 13:40:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 13:45:38 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 13:47:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed6fea15a9f025c4e928878822cfe7c5ee28d081
Cr-Commit-Position: refs/heads/master@{#33239}

Powered by Google App Engine
This is Rietveld 408576698