Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Side by Side Diff: chrome/browser/resources/history/externs.js

Issue 1574063003: MD History: Add basic material design history cards and history items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replaced with correct file names and links Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 /**
6 * @fileoverview Externs for objects sent from C++ to chrome://history.
7 * @externs
8 */
9
10 /**
11 * The type of the history result object. The definition is based on
12 * chrome/browser/ui/webui/history_ui.cc:
13 * BrowsingHistoryHandler::HistoryEntry::ToValue()
14 * @typedef {{allTimestamps: Array<number>,
15 * blockedVisit: (boolean|undefined),
16 * dateRelativeDay: (string|undefined),
17 * dateShort: string,
18 * dateTimeOfDay: (string|undefined),
19 * deviceName: string,
20 * deviceType: string,
21 * domain: string,
22 * hostFilteringBehavior: (number|undefined),
23 * snippet: (string|undefined),
Dan Beam 2016/01/26 23:07:39 can you just change the C++ so that these are more
yingran 2016/01/27 00:30:34 Done.
24 * starred: boolean,
25 * time: number,
26 * title: string,
27 * url: string}}
28 */
29 var HistoryEntry;
30
31 /**
32 * The type of the history results info object. The definition is based on
33 * chrome/browser/ui/webui/history_ui.cc:
34 * BrowsingHistoryHandler::QueryComplete()
35 * @typedef {{finished: boolean,
36 * hasSyncedResults: (boolean|undefined),
Dan Beam 2016/01/26 23:07:39 can this just always be a boolean?
yingran 2016/01/27 00:30:34 Done.
37 * queryEndTime: string,
38 * queryStartTime: string,
39 * term: string}}
40 */
41 var HistoryQuery;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698