chrome/browser/resources/md_history/compiled_resources.gyp - Issue 1574063003: MD History: Add basic material design history cards and history items

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_history/compiled_resources.gyp

Issue 1574063003: MD History: Add basic material design history cards and history items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed reviewer's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Closure compiler definition for MD History. Not tied into the main closure

	6 # build while we get oriented with the system.

	7 # To compile:

	8 # GYP_GENERATORS=ninja tools/gyp/gyp --depth . -Goutput_dir=out_closure \

	9 # chrome/browser/resources/md_history/compiled_resources.gyp

	10 # ninja -C out_closure/Default
	Dan Beam 2016/01/28 01:11:19 why don't you want to check that this compiles con why don't you want to check that this compiles continuously? tsergeant 2016/01/28 02:27:55 Do you mean using the closure compile bot? I made Show quoted text On 2016/01/28 01:11:19, Dan Beam wrote: > why don't you want to check that this compiles continuously? Do you mean using the closure compile bot? I made that decision in early December, but at this stage I think we're familiar enough with it to enable continuous compilation. Dan Beam 2016/01/28 20:35:18 yes Show quoted text On 2016/01/28 02:27:55, tsergeant wrote: > On 2016/01/28 01:11:19, Dan Beam wrote: > > why don't you want to check that this compiles continuously? > > Do you mean using the closure compile bot? yes Show quoted text > I made that decision in early > December, but at this stage I think we're familiar enough with it to enable > continuous compilation. lgtm if you fix this tsergeant 2016/01/29 02:40:28 It turns out that the closure compile doesn't actu Show quoted text On 2016/01/28 20:35:18, Dan Beam wrote: > On 2016/01/28 02:27:55, tsergeant wrote: > > On 2016/01/28 01:11:19, Dan Beam wrote: > > > why don't you want to check that this compiles continuously? > > > > Do you mean using the closure compile bot? > > yes > > > I made that decision in early > > December, but at this stage I think we're familiar enough with it to enable > > continuous compilation. > > lgtm if you fix this It turns out that the closure compile doesn't actually pass with this patch alone due to missing history.js. It will pass correctly with the second patch (https://codereview.chromium.org/1572383006/) applied. The better solution would obviously be to fix it, but the two patches are otherwise ready to go, so we'd like to land this patch as-is and enable continuous compilation in the second patch, which should also land today.
	11 {

	12 'targets': [

	13 {

	14 'target_name': 'history',

	15

	16 'variables': {

	17 'depends': [

	18 '../../../../ui/webui/resources/js/cr.js',

	19 '../../../../ui/webui/resources/js/util.js',

	20 '../../../../ui/webui/resources/js/cr/ui/position_util.js',

	21 'history_card_manager.js',

	22 'history_card.js',

	23 'history_item.js',

	24 ],

	25 'externs': [

	26 '<(EXTERNS_DIR)/chrome_send.js',

	27 '../history/externs.js',

	28 ],

	29 },

	30

	31 'includes': ['../../../../third_party/closure_compiler/compile_js.gypi'],

	32 },

	33 ],

	34 }

OLD	NEW

« chrome/browser/browser_resources.grd ('K') | « chrome/browser/resources/history/history.js ('k') | chrome/browser/resources/md_history/history_card.html » ('j') | no next file with comments »