Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: chrome/browser/resources/md_history/history_item.html

Issue 1574063003: MD History: Add basic material design history cards and history items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed reviewer's comments & changed default values of history result Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
7
8 <dom-module id="history-item">
9 <template>
10 <style>
11 #main-container {
12 @apply(--layout-center);
13 @apply(--layout-horizontal);
14 min-height: 40px;
15 }
16
17 paper-checkbox {
18 --paper-checkbox-checked-color: #48f;
19 --paper-checkbox-size: 16px;
20 --paper-checkbox-unchecked-color: #969696;
21 height: 16px;
22 margin: 0 16px 0 20px;
23 padding: 2px;
24 width: 16px;
25 }
26
27 #time {
28 color: #646464;
29 min-width: 96px;
30 }
31
32 #title {
33 color: #333;
34 overflow: hidden;
35 text-decoration: none;
36 text-overflow: ellipsis;
37 white-space: nowrap;
38 }
39
40 #title:hover {
41 text-decoration: underline;
42 }
43
44 #domain {
45 @apply(--layout-flex);
46 -webkit-margin-start: 16px;
47 color: #969696;
48 white-space: nowrap;
49 }
50
51 iron-icon {
52 --iron-icon-height: 16px;
53 --iron-icon-width: 16px;
54 }
55
56 #website-icon {
57 -webkit-margin-end: 16px;
58 height: 16px;
59 min-width: 16px;
60 }
61
62 #menu-button {
63 -webkit-margin-end: 12px;
64 -webkit-margin-start: 2px;
65 color: #969696;
66 height: 36px;
67 min-width: 36px;
Dan Beam 2016/01/27 03:07:31 why both min-width and width?
yingran 2016/01/27 05:05:04 Done.
yingran 2016/01/28 00:51:00 Actually needed both - just took a close look. Mi
Dan Beam 2016/01/28 01:25:23 you should probably be setting a min-width or flex
68 width: 36px;
69 }
70
71 #bookmark {
72 -webkit-margin-end: 10px;
73 -webkit-margin-start: 20px;
74 color: #48f;
75 min-width: 16px;
76 visibility: hidden;
77 }
78
79 :host([starred]) #bookmark {
80 visibility: visible;
81 }
82 </style>
83 <div id="main-container">
84 <paper-checkbox id="checkbox" on-tap="onCheckboxSelected_"
85 checked="{{selected}}">
86 </paper-checkbox>
87 <span id="time">{{timeAccessed}}</span>
88 <div id="website-icon"></div>
89 <a href="{{websiteUrl}}" id="title">{{websiteTitle}}</a>
90 <span id="domain">{{websiteDomain}}</span>
91 <iron-icon icon="star" id="bookmark"></iron-icon>
92 <paper-icon-button icon="more-vert" id="menu-button"
93 on-tap="onMenuButtonTap_">
94 </paper-icon-button>
95 </div>
96 </template>
97 <script src="chrome://history/history_item.js"></script>
98
Dan Beam 2016/01/27 03:07:31 nit: why \n here?
yingran 2016/01/27 05:05:04 Done.
99 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698