Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> | |
| 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.htm l"> | |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html"> | |
| 4 <link rel="import" href="chrome://history/history-item.html"> | |
| 5 | |
| 6 <dom-module id="history-card"> | |
| 7 <template> | |
| 8 <style> | |
|
Dan Beam
2016/01/16 02:54:36
is there a reason why you're doing the styling inl
yingran
2016/01/18 05:40:29
We're following what is suggested by the Polymer s
| |
| 9 :host { | |
| 10 @apply(--layout-center); | |
| 11 @apply(--layout-vertical); | |
| 12 padding: 0 24px 20px 24px; | |
| 13 } | |
| 14 | |
| 15 #main-container { | |
| 16 @apply(--shadow-elevation-2dp); | |
| 17 background: #fff; | |
| 18 border-radius: 2px; | |
| 19 max-width: 960px; | |
| 20 width: 100%; | |
| 21 } | |
| 22 | |
| 23 #time-gap-separator { | |
| 24 border-left: 1px solid #888; | |
|
Dan Beam
2016/01/16 02:54:36
border-left -> -webkit-border-start if it should b
yingran
2016/01/18 05:40:29
Done.
| |
| 25 height: 15px; | |
| 26 margin-left: 77px; | |
|
Dan Beam
2016/01/16 02:54:36
margin-left -> -webkit-margin-start if it should b
yingran
2016/01/18 05:40:29
Done.
| |
| 27 } | |
| 28 | |
| 29 #date-accessed { | |
| 30 @apply(--layout-center); | |
| 31 @apply(--layout-horizontal); | |
| 32 background: #fafafa; | |
| 33 border-bottom: 1px solid rgba(0, 0, 0, 0.14); | |
| 34 border-radius: 2px 2px 0 0; | |
|
Dan Beam
2016/01/16 02:54:36
RTL?
yingran
2016/01/18 05:40:29
Border radius also applies for top left & right in
| |
| 35 color: #333; | |
| 36 font-size: 14px; | |
|
Dan Beam
2016/01/16 02:54:36
this should be expressed in % or em instead of px
yingran
2016/01/18 05:40:29
Can we change all the font sizes for %/em in a sep
| |
| 37 font-weight: 500; | |
| 38 height: 48px; | |
| 39 padding-left: 20px; | |
| 40 } | |
| 41 | |
| 42 #history-item-list { | |
| 43 padding: 8px 0; | |
| 44 } | |
| 45 </style> | |
| 46 | |
| 47 <div id="main-container"> | |
| 48 <div id="date-accessed"> | |
| 49 {{historyDate}} | |
| 50 </div> | |
|
Dan Beam
2016/01/16 02:54:36
nit: <div id="date-accessed">{{historyDate}}</div>
yingran
2016/01/18 05:40:29
Done.
| |
| 51 <div id="history-item-list"> | |
| 52 <template is="dom-repeat" items="{{historyItems}}" | |
| 53 as="historyItem"> | |
| 54 <history-item time-accessed="{{historyItem.dateTimeOfDay}}" | |
| 55 website-title="{{historyItem.title}}" | |
| 56 website-domain="{{historyItem.domain}}" | |
| 57 website-url="{{historyItem.url}}" | |
| 58 starred="{{historyItem.starred}}" | |
| 59 selected="{{historyItem.selected}}" | |
| 60 timestamp="{{historyItem.time}}"> | |
| 61 </history-item> | |
| 62 <template is="dom-if" if="{{needsTimeGap_(index, historyItem)}}"> | |
| 63 <div id="time-gap-separator"></div> | |
| 64 </template> | |
| 65 </template> | |
| 66 </div> | |
| 67 </div> | |
| 68 </template> | |
| 69 <script src="chrome://history/history-card.js"></script> | |
| 70 </dom-module> | |
| OLD | NEW |