Issue 1574053002: Move NameFilter to its own file so it can be conveniently reused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1574053002: Move NameFilter to its own file so it can be conveniently reused. (Closed)

Created:
4 years, 11 months ago by Paul Berry

Modified:
4 years, 11 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Move NameFilter to its own file so it can be conveniently reused. This avoids some duplication of logic in summarize_elements.dart. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/4e0546ef441149ece0e98d40ba0917d73757bbc6

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+201 lines, -356 lines)			Patch
A	pkg/analyzer/lib/src/summary/name_filter.dart	View	1 chunk	+123 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/prelink.dart	View	4 chunks	+4 lines, -91 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	3 chunks	+5 lines, -21 lines	0 comments	Download
A +	pkg/analyzer/test/src/summary/name_filter_test.dart	View	15 chunks	+67 lines, -29 lines	0 comments	Download
D	pkg/analyzer/test/src/summary/prelink_test.dart	View	1 chunk	+0 lines, -213 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/test_all.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 11 months ago (2016-01-11 23:47:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e0546ef441149ece0e98d40ba0917d73757bbc6 (presubmit successful).