Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1574033002: Speed up download_android_tools.py by about a third. (Closed)

Created:
4 years, 11 months ago by tonyg
Modified:
4 years, 11 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Speed up download_android_tools.py by about a third. This moves extracting off of the main thread, so that it can be done in parallel with downloading. On my machine, this goes from about 76s -> 51s. But my motivation is to improve the time this takes on travis where it's even slower. BUG= R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/38633db5eccca39059a1149700f38c2639b7dcb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M tools/android/download_android_tools.py View 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
tonyg
4 years, 11 months ago (2016-01-11 22:05:04 UTC) #3
jamesr
lgtm
4 years, 11 months ago (2016-01-11 22:07:18 UTC) #4
tonyg
4 years, 11 months ago (2016-01-11 22:09:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38633db5eccca39059a1149700f38c2639b7dcb4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698