Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 157403006: Add QUIC_VERSION_15 to add a revived_packets set to replace the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_received_packet_manager_test.cc ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index bcdbc51c00d5b3722322cf886ea1daae5945ece0..0c63614055b5b5219e85dbec0bf2ab8372b730b0 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -252,6 +252,26 @@ void QuicSentPacketManager::HandleAckForSentPackets(
ack_notifier_manager_.OnPacketAcked(sequence_number);
}
+ // Discard any retransmittable frames associated with revived packets.
+ for (SequenceNumberSet::const_iterator revived_it =
+ received_info.revived_packets.begin();
+ revived_it != received_info.revived_packets.end(); ++revived_it) {
+ TransmissionInfo* transmission_info =
+ FindOrNull(unacked_packets_, *revived_it);
+ if (transmission_info == NULL) {
+ continue;
+ }
+ // The retransmittable frames are removed from the most recent transmission.
+ transmission_info =
+ FindOrNull(unacked_packets_,
+ *transmission_info->all_transmissions->rbegin());
+ if (transmission_info->retransmittable_frames == NULL) {
+ continue;
+ }
+ delete transmission_info->retransmittable_frames;
+ transmission_info->retransmittable_frames = NULL;
+ }
+
// If we have received a truncated ack, then we need to
// clear out some previous transmissions to allow the peer
// to actually ACK new packets.
« no previous file with comments | « net/quic/quic_received_packet_manager_test.cc ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698