Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: net/quic/quic_received_packet_manager.cc

Issue 157403006: Add QUIC_VERSION_15 to add a revived_packets set to replace the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/quic/quic_received_packet_manager.h ('k') | net/quic/quic_received_packet_manager_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_received_packet_manager.h" 5 #include "net/quic/quic_received_packet_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/stl_util.h" 8 #include "base/stl_util.h"
9 #include "net/base/linked_hash_map.h" 9 #include "net/base/linked_hash_map.h"
10 10
(...skipping 25 matching lines...) Expand all
36 receive_algorithm_(ReceiveAlgorithmInterface::Create(congestion_type)) { 36 receive_algorithm_(ReceiveAlgorithmInterface::Create(congestion_type)) {
37 received_info_.largest_observed = 0; 37 received_info_.largest_observed = 0;
38 received_info_.entropy_hash = 0; 38 received_info_.entropy_hash = 0;
39 } 39 }
40 40
41 QuicReceivedPacketManager::~QuicReceivedPacketManager() {} 41 QuicReceivedPacketManager::~QuicReceivedPacketManager() {}
42 42
43 void QuicReceivedPacketManager::RecordPacketReceived( 43 void QuicReceivedPacketManager::RecordPacketReceived(
44 QuicByteCount bytes, 44 QuicByteCount bytes,
45 const QuicPacketHeader& header, 45 const QuicPacketHeader& header,
46 QuicTime receipt_time, 46 QuicTime receipt_time) {
47 bool revived) {
48 QuicPacketSequenceNumber sequence_number = header.packet_sequence_number; 47 QuicPacketSequenceNumber sequence_number = header.packet_sequence_number;
49 DCHECK(IsAwaitingPacket(sequence_number)); 48 DCHECK(IsAwaitingPacket(sequence_number));
50 49
51 InsertMissingPacketsBetween( 50 InsertMissingPacketsBetween(
52 &received_info_, 51 &received_info_,
53 max(received_info_.largest_observed + 1, peer_least_packet_awaiting_ack_), 52 max(received_info_.largest_observed + 1, peer_least_packet_awaiting_ack_),
54 header.packet_sequence_number); 53 header.packet_sequence_number);
55 54
56 if (received_info_.largest_observed > header.packet_sequence_number) { 55 if (received_info_.largest_observed > header.packet_sequence_number) {
57 // We've gotten one of the out of order packets - remove it from our 56 // We've gotten one of the out of order packets - remove it from our
58 // "missing packets" list. 57 // "missing packets" list.
59 DVLOG(1) << "Removing " << sequence_number << " from missing list"; 58 DVLOG(1) << "Removing " << sequence_number << " from missing list";
60 received_info_.missing_packets.erase(sequence_number); 59 received_info_.missing_packets.erase(sequence_number);
61 } 60 }
62 if (header.packet_sequence_number > received_info_.largest_observed) { 61 if (header.packet_sequence_number > received_info_.largest_observed) {
63 received_info_.largest_observed = header.packet_sequence_number; 62 received_info_.largest_observed = header.packet_sequence_number;
64 time_largest_observed_ = receipt_time; 63 time_largest_observed_ = receipt_time;
65 } 64 }
66 RecordPacketEntropyHash(sequence_number, header.entropy_hash); 65 RecordPacketEntropyHash(sequence_number, header.entropy_hash);
67 66
68 // Don't update the receive algorithm for revived packets. 67 receive_algorithm_->RecordIncomingPacket(
69 if (!revived) { 68 bytes, sequence_number, receipt_time);
70 receive_algorithm_->RecordIncomingPacket( 69 }
71 bytes, sequence_number, receipt_time); 70
72 } 71 void QuicReceivedPacketManager::RecordPacketRevived(
72 QuicPacketSequenceNumber sequence_number) {
73 LOG_IF(DFATAL, !IsAwaitingPacket(sequence_number));
74 received_info_.revived_packets.insert(sequence_number);
73 } 75 }
74 76
75 bool QuicReceivedPacketManager::IsMissing( 77 bool QuicReceivedPacketManager::IsMissing(
76 QuicPacketSequenceNumber sequence_number) { 78 QuicPacketSequenceNumber sequence_number) {
77 return ContainsKey(received_info_.missing_packets, sequence_number); 79 return ContainsKey(received_info_.missing_packets, sequence_number);
78 } 80 }
79 81
80 bool QuicReceivedPacketManager::IsAwaitingPacket( 82 bool QuicReceivedPacketManager::IsAwaitingPacket(
81 QuicPacketSequenceNumber sequence_number) { 83 QuicPacketSequenceNumber sequence_number) {
82 return ::net::IsAwaitingPacket(received_info_, sequence_number); 84 return ::net::IsAwaitingPacket(received_info_, sequence_number);
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 if (incoming_ack.received_info.missing_packets.empty()) { 191 if (incoming_ack.received_info.missing_packets.empty()) {
190 least_packet_awaited_by_peer_ = peer_largest_observed_packet_ + 1; 192 least_packet_awaited_by_peer_ = peer_largest_observed_packet_ + 1;
191 } else { 193 } else {
192 least_packet_awaited_by_peer_ = 194 least_packet_awaited_by_peer_ =
193 *(incoming_ack.received_info.missing_packets.begin()); 195 *(incoming_ack.received_info.missing_packets.begin());
194 } 196 }
195 } 197 }
196 198
197 bool QuicReceivedPacketManager::DontWaitForPacketsBefore( 199 bool QuicReceivedPacketManager::DontWaitForPacketsBefore(
198 QuicPacketSequenceNumber least_unacked) { 200 QuicPacketSequenceNumber least_unacked) {
201 received_info_.revived_packets.erase(
202 received_info_.revived_packets.begin(),
203 received_info_.revived_packets.lower_bound(least_unacked));
199 size_t missing_packets_count = received_info_.missing_packets.size(); 204 size_t missing_packets_count = received_info_.missing_packets.size();
200 received_info_.missing_packets.erase( 205 received_info_.missing_packets.erase(
201 received_info_.missing_packets.begin(), 206 received_info_.missing_packets.begin(),
202 received_info_.missing_packets.lower_bound(least_unacked)); 207 received_info_.missing_packets.lower_bound(least_unacked));
203 return missing_packets_count != received_info_.missing_packets.size(); 208 return missing_packets_count != received_info_.missing_packets.size();
204 } 209 }
205 210
206 void QuicReceivedPacketManager::UpdatePacketInformationSentByPeer( 211 void QuicReceivedPacketManager::UpdatePacketInformationSentByPeer(
207 const QuicAckFrame& incoming_ack) { 212 const QuicAckFrame& incoming_ack) {
208 // ValidateAck() should fail if peer_least_packet_awaiting_ack_ shrinks. 213 // ValidateAck() should fail if peer_least_packet_awaiting_ack_ shrinks.
(...skipping 21 matching lines...) Expand all
230 return !received_info_.missing_packets.empty(); 235 return !received_info_.missing_packets.empty();
231 } 236 }
232 237
233 bool QuicReceivedPacketManager::HasNewMissingPackets() { 238 bool QuicReceivedPacketManager::HasNewMissingPackets() {
234 return HasMissingPackets() && 239 return HasMissingPackets() &&
235 (received_info_.largest_observed - 240 (received_info_.largest_observed -
236 *received_info_.missing_packets.rbegin()) <= kMaxPacketsAfterNewMissing; 241 *received_info_.missing_packets.rbegin()) <= kMaxPacketsAfterNewMissing;
237 } 242 }
238 243
239 } // namespace net 244 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_received_packet_manager.h ('k') | net/quic/quic_received_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698