move declaration of CreateLightingFilter into SkColorMatrixFilter

move declaration of CreateLightingFilter into SkColorMatrixFilter

BUG=skia:4791
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1574023002

Committed: https://skia.googlesource.com/skia/+/0daf5dd7fc682c939325e16cac6f8aa2e1295060

[reed1, 2016-01-11 20:06:50]

Description was changed from

==========
move declaration of CreateLightingFilter into SkColorMatrixFilter

BUG=skia:
==========

to

==========
move declaration of CreateLightingFilter into SkColorMatrixFilter

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-11 20:07:05]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2016-01-11 20:07:20]

Description was changed from

==========
move declaration of CreateLightingFilter into SkColorMatrixFilter

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
move declaration of CreateLightingFilter into SkColorMatrixFilter

BUG=skia:4791
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-11 20:11:29]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 20:11:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1574023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1574023002/1

[f(malita), 2016-01-11 20:13:55]

lgtm

https://codereview.chromium.org/1574023002/diff/1/include/core/SkColorFilter.h
File include/core/SkColorFilter.h (right):

https://codereview.chromium.org/1574023002/diff/1/include/core/SkColorFilter....
include/core/SkColorFilter.h:110: static SkColorFilter*
CreateLightingFilter(SkColor mul, SkColor add);
Nit: is this still needed?  I see we're removing the definition from
SkColorMatrixFilter.cpp, so I presume it's no longer used.

[reed1, 2016-01-11 20:19:55]

On 2016/01/11 20:13:55, f(malita) wrote:
> lgtm
> 
> https://codereview.chromium.org/1574023002/diff/1/include/core/SkColorFilter.h
> File include/core/SkColorFilter.h (right):
> 
>
https://codereview.chromium.org/1574023002/diff/1/include/core/SkColorFilter....
> include/core/SkColorFilter.h:110: static SkColorFilter*
> CreateLightingFilter(SkColor mul, SkColor add);
> Nit: is this still needed?  I see we're removing the definition from
> SkColorMatrixFilter.cpp, so I presume it's no longer used.

Oops, no, it needs to be there for the moment...

[reed1, 2016-01-11 20:22:11]

The CQ bit was checked by reed@google.com

[reed1, 2016-01-11 20:22:11]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1574023002/#ps20001
(title: "don't remove old impl yet")

[commit-bot: I haz the power, 2016-01-11 20:22:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1574023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1574023002/20001

[commit-bot: I haz the power, 2016-01-11 20:34:08]

Description was changed from

==========
move declaration of CreateLightingFilter into SkColorMatrixFilter

BUG=skia:4791
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
move declaration of CreateLightingFilter into SkColorMatrixFilter

BUG=skia:4791
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/0daf5dd7fc682c939325e16cac6f8aa2e1295060
==========

[commit-bot: I haz the power, 2016-01-11 20:34:09]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0daf5dd7fc682c939325e16cac6f8aa2e1295060