Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: content/browser/renderer_host/input/web_input_event_unittest.cc

Issue 1574013002: Remove the % WHEEL_DELTA check in WebMouseWheelEventBuilder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot rbyers nit Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/input/web_input_event_builders_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/input/web_input_event_unittest.cc
diff --git a/content/browser/renderer_host/input/web_input_event_unittest.cc b/content/browser/renderer_host/input/web_input_event_unittest.cc
index 677c54c0b6391d8ce022769e224760c3bb130c17..b05608fafef8ec80abf0a413852726ddb8973a23 100644
--- a/content/browser/renderer_host/input/web_input_event_unittest.cc
+++ b/content/browser/renderer_host/input/web_input_event_unittest.cc
@@ -54,41 +54,6 @@ TEST(WebInputEventBuilderTest, TestMouseEventScale) {
command_line->AppendSwitchASCII(switches::kForceDeviceScaleFactor, "1");
gfx::Display::ResetForceDeviceScaleFactorForTesting();
}
-
-// Test that hasPreciseScrollingDeltas is true for wheel events that generate
-// high precision scroll deltas.
-TEST(WebInputEventBuilderTest, TestPreciseScrollingDelta) {
- LPARAM lparam = MAKELPARAM(300, 200);
-
- // wheel_delta is equal to WHEEL_DELTA, scroll up
- WebMouseWheelEvent evt =
- WebMouseWheelEventBuilder::Build(::GetDesktopWindow(), WM_MOUSEWHEEL,
- MAKEWPARAM(0, 120), lparam, 100);
- EXPECT_EQ(1, evt.wheelTicksY);
- EXPECT_EQ(100, evt.deltaY);
- EXPECT_FALSE(evt.hasPreciseScrollingDeltas);
-
- // wheel_delta is a multiple of WHEEL_DELTA, scroll up
- evt = WebMouseWheelEventBuilder::Build(::GetDesktopWindow(), WM_MOUSEWHEEL,
- MAKEWPARAM(0, 360), lparam, 100);
- EXPECT_EQ(3, evt.wheelTicksY);
- EXPECT_EQ(300, evt.deltaY);
- EXPECT_FALSE(evt.hasPreciseScrollingDeltas);
-
- // wheel_delta is a multiple of WHEEL_DELTA, scroll down
- evt = WebMouseWheelEventBuilder::Build(::GetDesktopWindow(), WM_MOUSEWHEEL,
- MAKEWPARAM(0, -360), lparam, 100);
- EXPECT_EQ(-3, evt.wheelTicksY);
- EXPECT_EQ(-300, evt.deltaY);
- EXPECT_FALSE(evt.hasPreciseScrollingDeltas);
-
- // high precision scroll, wheel_delta not a multiple of WHEEL_DELTA
- evt = WebMouseWheelEventBuilder::Build(::GetDesktopWindow(), WM_MOUSEWHEEL,
- MAKEWPARAM(0, 3), lparam, 100);
- EXPECT_FLOAT_EQ(0.025f, evt.wheelTicksY);
- EXPECT_FLOAT_EQ(2.5f, evt.deltaY);
- EXPECT_TRUE(evt.hasPreciseScrollingDeltas);
-}
#endif
} // namespace content
« no previous file with comments | « content/browser/renderer_host/input/web_input_event_builders_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698