Issue 1574003: Reapply svn r4269 plus fixes for issues 665 and 667.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1574003: Reapply svn r4269 plus fixes for issues 665 and 667. (Closed)

Created:
10 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Reapply svn r4269 plus fixes for issues 665 and 667. Reapply svn r4269, the C++ implementation of String.prototype.replace. Cherry pick fixes for V8 issues 665 (svn r4312) and 667 (svn r4322) from bleeding_edge. Committed: http://code.google.com/p/v8/source/detail?r=4325

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+723 lines, -126 lines)			Patch
M	src/regexp.js	View	5 chunks	+38 lines, -7 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	10 chunks	+594 lines, -41 lines	0 comments	Download
M	src/string.js	View	2 chunks	+77 lines, -76 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/string-replace.js	View	1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

Reapplying r4269 to the 2.1 branch, along with fixes for the two issues that caused ...

10 years, 8 months ago (2010-03-30 13:47:36 UTC) #1

LGTM

Expand Messages | Collapse Messages