Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 15740028: The different drawing pipeline on windows content shell produces slightly different pixel results d… (Closed)

Created:
7 years, 6 months ago by ojan
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

The different drawing pipeline on windows content shell produces slightly different pixel results due to differences in the fixed point arithmetic implementation, but are otherwise correct. BUG=239769 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -93 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -93 lines 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/composited-reflected-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/crash-filter-change-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/custom/custom-filter-color-matrix-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-blur-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-blur-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-combined-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-contrast-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-drop-shadow-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-grayscale-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-grayscale-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-hue-rotate-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-hue-rotate-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-invert-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-invert-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-opacity-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-opacity-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-reference-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-reference-external-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-reference-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-reference-ordering-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-reference-subregion-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-saturate-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-sepia-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/css3/filters/regions-expanding-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/fast/images/webp-color-profile-lossless-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/fast/images/webp-color-profile-lossy-alpha-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/fast/images/webp-color-profile-lossy-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/svg/custom/createImageElement-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/svg/custom/group-opacity-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/svg/custom/js-update-image-and-display-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/svg/custom/js-update-image-and-display2-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/svg/custom/js-update-image-and-display3-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/svg/custom/js-update-image-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/svg/filters/filter-source-position-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/virtual/deferred/fast/images/exif-orientation-image-document-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/virtual/deferred/fast/images/jpeg-with-color-profile-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/virtual/deferred/fast/images/png-with-color-profile-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/virtual/deferred/fast/images/webp-color-profile-lossless-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/virtual/deferred/fast/images/webp-color-profile-lossy-alpha-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/virtual/deferred/fast/images/webp-color-profile-lossy-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-linux/virtual/gpu/compositedscrolling/scrollbars/listbox-scrollbar-combinations-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/compositing/color-matching/image-color-matching-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/composited-reflected-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/crash-filter-change-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/custom/custom-filter-color-matrix-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/custom/custom-filter-shader-cache-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/custom/effect-custom-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/custom/missing-custom-filter-shader-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-blur-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-blur-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-brightness-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-brightness-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-combined-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-combined-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-contrast-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-contrast-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-drop-shadow-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-grayscale-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-hue-rotate-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-invert-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-invert-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-opacity-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-opacity-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-reference-external-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-reference-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-reference-ordering-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-reference-subregion-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-saturate-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-saturate-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-sepia-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/effect-sepia-hw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/css3/filters/regions-expanding-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/exif-orientation-css-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/exif-orientation-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/exif-orientation-image-document-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/jpeg-with-color-profile-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/png-with-color-profile-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossless-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossy-alpha-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/fast/images/webp-color-profile-lossy-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/createImageElement-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/createImageElement2-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/focus-ring-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/group-opacity-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/image-parent-translation-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/image-small-width-height-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/js-update-image-and-display-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/js-update-image-and-display2-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/js-update-image-and-display3-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/js-update-image-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/text-image-opacity-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/filters/filter-source-position-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/deferred/fast/images/color-jpeg-with-color-profile-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/virtual/deferred/fast/images/exif-orientation-css-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/virtual/deferred/fast/images/exif-orientation-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/deferred/fast/images/exif-orientation-image-document-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/virtual/deferred/fast/images/gif-large-checkerboard-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/deferred/fast/images/jpeg-with-color-profile-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/deferred/fast/images/png-with-color-profile-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/deferred/fast/images/webp-color-profile-lossless-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/deferred/fast/images/webp-color-profile-lossy-alpha-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/deferred/fast/images/webp-color-profile-lossy-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/gpu/compositedscrolling/scrollbars/listbox-scrollbar-combinations-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/virtual/softwarecompositing/color-matching/image-color-matching-expected.png View Binary file 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
Committed patchset #1 manually as r151286 (presubmit successful).
7 years, 6 months ago (2013-05-28 19:13:40 UTC) #1
jochen (gone - plz use gerrit)
7 years, 6 months ago (2013-05-28 19:17:04 UTC) #2
Message was sent while issue was closed.
93 less test expectations :)

lgtm

Powered by Google App Engine
This is Rietveld 408576698