Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15740023: Revert "Revert 202112 "GTTF: Convert most tests in content to use Embedd..."" (Closed)

Created:
7 years, 6 months ago by Paweł Hajdan Jr.
Modified:
7 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, feature-media-reviews_chromium.org, benjhayden+dwatch_chromium.org, tfarina, jam, dcheng, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert "Revert 202112 "GTTF: Convert most tests in content to use Embedd..."" This is a resubmit of https://codereview.chromium.org/15505003 TBR=avi BUG=96594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -196 lines) Patch
M chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations_unittest.cc View 9 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 10 chunks +33 lines, -20 lines 0 comments Download
M chrome/browser/google_apis/test_util.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/test_util.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore_provider_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 39 chunks +97 lines, -48 lines 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 12 chunks +46 lines, -24 lines 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 15 chunks +16 lines, -15 lines 0 comments Download
M content/browser/media/webrtc_internals_browsertest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 3 chunks +13 lines, -8 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 4 chunks +34 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/browser_plugin_dragging.html View 2 chunks +7 lines, -0 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 2 chunks +22 lines, -21 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/http_response.h View 3 chunks +20 lines, -6 lines 0 comments Download
M net/test/embedded_test_server/http_response.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/test/embedded_test_server/http_response_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
Committed patchset #1 manually as r202586 (presubmit successful).
7 years, 6 months ago (2013-05-28 17:00:42 UTC) #1
Paweł Hajdan Jr.
7 years, 6 months ago (2013-05-28 18:24:52 UTC) #2
Message was sent while issue was closed. 
TBR

Previous landing was reverted because of some redness on CrOS ASAN bots, that I
don't see now.

Powered by Google App Engine
This is Rietveld 408576698