Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: test/cctest/test-assembler-mips64.cc

Issue 1573953002: MIPS: Fix dd() implementations for compact branches. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-assembler-mips64.cc
diff --git a/test/cctest/test-assembler-mips64.cc b/test/cctest/test-assembler-mips64.cc
index 5bdac0012f9973c8f5a33fc991bdbe70b895ba34..e16ca25fc7bb1dec8c1854df0410d112042aa8f4 100644
--- a/test/cctest/test-assembler-mips64.cc
+++ b/test/cctest/test-assembler-mips64.cc
@@ -3372,6 +3372,7 @@ TEST(jump_tables3) {
Label done, dispatch;
__ b(&dispatch);
+ __ nop();
for (int i = 0; i < kNumCases; ++i) {
@@ -3386,7 +3387,6 @@ TEST(jump_tables3) {
__ nop();
}
- __ stop("chk");
if ((assm.pc_offset() & 7) == 0) {
__ nop();
ivica.bogosavljevic 2016/01/12 15:14:29 This should probably be __ Align(8), right?
balazs.kilvady 2016/01/12 17:49:48 Done.
}
@@ -5547,9 +5547,8 @@ int64_t run_bc(int32_t offset) {
__ li(t8, 0);
__ li(t9, 2); // Condition for the stopping execution.
- uint32_t instruction_addiu = 0x24420001; // addiu v0, v0, 1
for (int32_t i = -100; i <= -11; ++i) {
- __ dd(instruction_addiu);
+ __ addiu(v0, v0, 1);
}
__ addiu(t8, t8, 1); // -10
@@ -5568,7 +5567,7 @@ int64_t run_bc(int32_t offset) {
__ bc(offset); // -1
for (int32_t i = 0; i <= 99; ++i) {
- __ dd(instruction_addiu);
+ __ addiu(v0, v0, 1);
}
__ pop(ra);

Powered by Google App Engine
This is Rietveld 408576698