MIPS: Fix dd() implementations for compact branches.

MIPS: Fix dd() implementations for compact branches.

BUG=

Committed: https://crrev.com/5091e8f2f5d83a7061e88bb0ef2399e4b042ae0d
Cr-Commit-Position: refs/heads/master@{#33249}

[balazs.kilvady, 2016-01-11 17:36:19]

balazs.kilvady@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, ivica.bogosavljevic@imgtec.com, paul.lind@imgtec.com

[paul.l..., 2016-01-12 01:13:41]

https://codereview.chromium.org/1573953002/diff/1/src/mips/assembler-mips-inl.h
File src/mips/assembler-mips-inl.h (right):

https://codereview.chromium.org/1573953002/diff/1/src/mips/assembler-mips-inl...
src/mips/assembler-mips-inl.h:440: void Assembler::EmitForbiddenSlotHelper() {
Maybe CheckForEmitInForbiddenSlot() is a better name? (too many Helpers :)

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-macro-asse...
File test/cctest/test-macro-assembler-mips.cc (right):

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:265: if (IsMipsArchVariant(kMips32r6))
return;
I suspect this should be ! IsMipsArchVariant(kMips32r6)

You use a bc() instruction below which is only r6.

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:270: // Regression test for v8:4294.
Is this still a regression for that issue? Or was this just cut/paste from
above?

[ivica.bogosavljevic, 2016-01-12 15:14:29]

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips64.cc (right):

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips64.cc:3391: __ nop();
This should probably be __ Align(8), right?

[balazs.kilvady, 2016-01-12 16:32:11]

https://codereview.chromium.org/1573953002/diff/1/src/mips/assembler-mips-inl.h
File src/mips/assembler-mips-inl.h (right):

https://codereview.chromium.org/1573953002/diff/1/src/mips/assembler-mips-inl...
src/mips/assembler-mips-inl.h:440: void Assembler::EmitForbiddenSlotHelper() {
On 2016/01/12 01:13:40, paul.l... wrote:
> Maybe CheckForEmitInForbiddenSlot() is a better name? (too many Helpers :)

Done.

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-macro-asse...
File test/cctest/test-macro-assembler-mips.cc (right):

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:265: if (IsMipsArchVariant(kMips32r6))
return;
On 2016/01/12 01:13:40, paul.l... wrote:
> I suspect this should be ! IsMipsArchVariant(kMips32r6)
> 
> You use a bc() instruction below which is only r6.

Done.

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:270: // Regression test for v8:4294.
On 2016/01/12 01:13:40, paul.l... wrote:
> Is this still a regression for that issue? Or was this just cut/paste from
> above?

Done.

[balazs.kilvady, 2016-01-12 17:49:48]

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips64.cc (right):

https://codereview.chromium.org/1573953002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips64.cc:3391: __ nop();
On 2016/01/12 15:14:29, ivica.bogosavljevic wrote:
> This should probably be __ Align(8), right?

Done.

[paul.l..., 2016-01-12 19:07:36]

LGTM.

[balazs.kilvady, 2016-01-12 19:09:26]

The CQ bit was checked by balazs.kilvady@imgtec.com

[commit-bot: I haz the power, 2016-01-12 19:09:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573953002/40001

[commit-bot: I haz the power, 2016-01-12 19:48:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 19:49:24]

Description was changed from

==========
MIPS: Fix dd() implementations for compact branches.

BUG=
==========

to

==========
MIPS: Fix dd() implementations for compact branches.

BUG=

Committed: https://crrev.com/5091e8f2f5d83a7061e88bb0ef2399e4b042ae0d
Cr-Commit-Position: refs/heads/master@{#33249}
==========

[commit-bot: I haz the power, 2016-01-12 19:49:25]

Patchset 3 (id:??) landed as
https://crrev.com/5091e8f2f5d83a7061e88bb0ef2399e4b042ae0d
Cr-Commit-Position: refs/heads/master@{#33249}