Issue 157393002: Prevent race between GC and interrupts from other threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 157393002: Prevent race between GC and interrupts from other threads. (Closed)

Created:
6 years, 10 months ago by Yang

Modified:
6 years, 10 months ago

Reviewers:
Sven Panne, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prevent race between GC and interrupts from other threads. R=svenpanne@chromium.org BUG=328804 LOG=N

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/heap.cc	View		1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

6 years, 10 months ago (2014-02-07 10:24:50 UTC) #3

Not LGTM.

https://codereview.chromium.org/157393002/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/157393002/diff/1/src/heap.cc#newcode6088
src/heap.cc:6088: ExecutionAccess access(isolate());
As discussed offline: This seems very much like a redundant lock to me. I know
the motivation is to make TSAN happy, but I have issues with taking a lock in
IterateStringRoots, especially for a field that is _always_ a SMI.

One suggestion from my end would be to reorder the strong roots list in a way
that groups SMIs at the end so that the GC doesn't need to look at them at all.

Expand Messages | Collapse Messages