Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 1573913009: Revert of Enable DirectComposition by default. (Closed)

Created:
4 years, 11 months ago by Zhenyao Mo
Modified:
4 years, 11 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable DirectComposition by default. (patchset #2 id:20001 of https://codereview.chromium.org/1578453003/ ) Reason for revert: This seems to break gles2_conform_test on win8 bots Original issue's description: > Enable DirectComposition by default. > > Chrome will now use DirectComposition where supported (Win8+ with d3d11 rendering). --disable-direct-composition can be specified to disable it, and a disable_direct_composition driver bug workaround type has been added. > > BUG=524838 > > Committed: https://crrev.com/88b36341a5868273eeeb08d42047721e00f495d6 > Cr-Commit-Position: refs/heads/master@{#369289} TBR=kbr@chromium.org,jbauman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524838 Committed: https://crrev.com/e463401bc88116d770ba6ed209f9066a84155a4c Cr-Commit-Position: refs/heads/master@{#369481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_switches.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Zhenyao Mo
Created Revert of Enable DirectComposition by default.
4 years, 11 months ago (2016-01-14 18:38:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573913009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573913009/1
4 years, 11 months ago (2016-01-14 18:39:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 18:43:35 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 18:44:19 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e463401bc88116d770ba6ed209f9066a84155a4c
Cr-Commit-Position: refs/heads/master@{#369481}

Powered by Google App Engine
This is Rietveld 408576698