Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1573913003: [swarming] Isolate mac asan. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Isolate mac asan. BUG=chromium:535160 LOG=n NOTRY=true TBR=tandrii@chromium.org, kjellander@chromium.org Committed: https://crrev.com/036e3e015fdc72f515316afbbdb5751859b52b0c Cr-Commit-Position: refs/heads/master@{#33210}

Patch Set 1 : Without fix #

Patch Set 2 : The fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/base.isolate View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL. Tested on swarming staging, which is mac asan at the moment.
4 years, 11 months ago (2016-01-11 16:01:38 UTC) #3
tandrii(chromium)
lgtm
4 years, 11 months ago (2016-01-11 16:14:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573913003/20001
4 years, 11 months ago (2016-01-11 16:23:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 16:28:25 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 16:29:14 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/036e3e015fdc72f515316afbbdb5751859b52b0c
Cr-Commit-Position: refs/heads/master@{#33210}

Powered by Google App Engine
This is Rietveld 408576698