Fix an assertion failure in CFX_RTFBreak::SetLineWidth()

Fix an assertion failure in CFX_RTFBreak::SetLineWidth()

BUG=pdfium:347
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/b9bc6b79cba90c5c0e28ab31276029aa0d0c04cb

[jun_fang, 2016-01-11 07:41:43]

Description was changed from

==========
Update for internal review


Update for self-review


Fix an assertion failure in CFX_RTFBreak::SetLineWidth()

BUG=pdfium:347
==========

to

==========
Fix an assertion failure in CFX_RTFBreak::SetLineWidth()

BUG=pdfium:347
==========

[jun_fang, 2016-01-11 07:45:33]

jun_fang@foxitsoftware.com changed reviewers:
+ kai_jing@foxitsoftware.com, thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2016-01-11 07:45:33]

Hi Tom and Lei,

Please review this patch. Thanks!

[Tom Sepez, 2016-01-11 17:16:11]

lgtm

https://codereview.chromium.org/1573893002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_rtfbreak.cpp (right):

https://codereview.chromium.org/1573893002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_rtfbreak.cpp:67: if (m_pCurLine->m_iStart <
m_iBoundaryStart)
nit: prefer std::min and std::max.

[jun_fang, 2016-01-12 02:52:39]

https://codereview.chromium.org/1573893002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_rtfbreak.cpp (right):

https://codereview.chromium.org/1573893002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_rtfbreak.cpp:67: if (m_pCurLine->m_iStart <
m_iBoundaryStart)
On 2016/01/11 17:16:11, Tom Sepez wrote:
> nit: prefer std::min and std::max.

can you explain it a little bit?

[Lei Zhang, 2016-01-12 03:01:53]

https://codereview.chromium.org/1573893002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_rtfbreak.cpp (right):

https://codereview.chromium.org/1573893002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_rtfbreak.cpp:67: if (m_pCurLine->m_iStart <
m_iBoundaryStart)
On 2016/01/12 02:52:39, jun_fang wrote:
> On 2016/01/11 17:16:11, Tom Sepez wrote:
> > nit: prefer std::min and std::max.
> 
> can you explain it a little bit?

void func1(int i, int j, int* result) {
  *result = i;
  if (*result < j)
    *result = j;
}

is equivalent to:

void func2(int i, int j, int* result) {
  *result = std::max(i, j);
}

[jun_fang, 2016-01-12 03:11:24]

On 2016/01/12 03:01:53, Lei Zhang wrote:
>
https://codereview.chromium.org/1573893002/diff/1/xfa/src/fgas/src/layout/fx_...
> File xfa/src/fgas/src/layout/fx_rtfbreak.cpp (right):
> 
>
https://codereview.chromium.org/1573893002/diff/1/xfa/src/fgas/src/layout/fx_...
> xfa/src/fgas/src/layout/fx_rtfbreak.cpp:67: if (m_pCurLine->m_iStart <
> m_iBoundaryStart)
> On 2016/01/12 02:52:39, jun_fang wrote:
> > On 2016/01/11 17:16:11, Tom Sepez wrote:
> > > nit: prefer std::min and std::max.
> > 
> > can you explain it a little bit?
> 
> void func1(int i, int j, int* result) {
>   *result = i;
>   if (*result < j)
>     *result = j;
> }
> 
> is equivalent to:
> 
> void func2(int i, int j, int* result) {
>   *result = std::max(i, j);
> }

Thanks!

[jun_fang, 2016-01-12 03:27:05]

Description was changed from

==========
Fix an assertion failure in CFX_RTFBreak::SetLineWidth()

BUG=pdfium:347
==========

to

==========
Fix an assertion failure in CFX_RTFBreak::SetLineWidth()

BUG=pdfium:347
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/b9bc6b79cba90c5c0e28ab31276029aa0d0c...
==========

[jun_fang, 2016-01-12 03:27:08]

Committed patchset #2 (id:20001) manually as
b9bc6b79cba90c5c0e28ab31276029aa0d0c04cb (presubmit successful).