Beat the transition tests with a sanity stick.

Clean up the transition tests.

Moves the transition test logic from transition-test-helpers to
animation-test-helpers. This allows us to run all animations/transitions
tests in a uniform way. Immediate benefit is that the transition tests
now use requestAnimationFrame rather than setTimeout when running in
real-time.

Several other cleanups
- Removed some tests that were redundant.
- Disabled pixel tests where we have coverage elsewhere.
- Updated expectations (since animation-test-helper produces simpler results)

BUG=235752
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150976

[Steve Block, 2013-05-23 03:47:09]

Not really sure how to review this! Is there a part that needs particular
attention?

https://codereview.chromium.org/15738009/diff/3001/LayoutTests/animations/res...
File LayoutTests/animations/resources/animation-test-helpers.js (right):

https://codereview.chromium.org/15738009/diff/3001/LayoutTests/animations/res...
LayoutTests/animations/resources/animation-test-helpers.js:295: function
checkExpectedTransitionValue(expected, index)
Have you changed this function at all from transition-test-helpers.js?

https://codereview.chromium.org/15738009/diff/3001/LayoutTests/animations/res...
LayoutTests/animations/resources/animation-test-helpers.js:671:
runAnimationTest(expected, callback, undefined, usePauseAPI !== true,
doPixelTest);
Regarding usePauseAPI, are there really cases where callers pass things other
than a boolean? If so, should we fix those call sites to avoid needing this?

[dstockwell, 2013-05-23 03:59:17]

On 2013/05/23 03:47:09, Steve Block wrote:
> Not really sure how to review this! Is there a part that needs particular
> attention?

There's not very much that's new here. I think it's pretty sound.

Would be helpful for second set of eyes to skim the expectations to make sure I
didn't miss anything obvious.

[dstockwell, 2013-05-23 03:59:33]

https://codereview.chromium.org/15738009/diff/3001/LayoutTests/animations/res...
File LayoutTests/animations/resources/animation-test-helpers.js (right):

https://codereview.chromium.org/15738009/diff/3001/LayoutTests/animations/res...
LayoutTests/animations/resources/animation-test-helpers.js:295: function
checkExpectedTransitionValue(expected, index)
On 2013/05/23 03:47:09, Steve Block wrote:
> Have you changed this function at all from transition-test-helpers.js?

Only some trivial changes, inlining some simple functions and changing
-webkit-box-shadow to box-shadow.

https://codereview.chromium.org/15738009/diff/3001/LayoutTests/animations/res...
LayoutTests/animations/resources/animation-test-helpers.js:671:
runAnimationTest(expected, callback, undefined, usePauseAPI !== true,
doPixelTest);
On 2013/05/23 03:47:09, Steve Block wrote:
> Regarding usePauseAPI, are there really cases where callers pass things other
> than a boolean? If so, should we fix those call sites to avoid needing this?

Done.

[Steve Block, 2013-05-23 05:17:20]

lgtm

https://codereview.chromium.org/15738009/diff/9001/LayoutTests/css3/calc/tran...
File LayoutTests/css3/calc/transitions-dependent.html (right):

https://codereview.chromium.org/15738009/diff/9001/LayoutTests/css3/calc/tran...
LayoutTests/css3/calc/transitions-dependent.html:54: // time, element, property,
expected-value, depends-on
Is this comment still correct?

https://codereview.chromium.org/15738009/diff/9001/LayoutTests/css3/calc/tran...
File LayoutTests/css3/calc/transitions-expected.txt (right):

https://codereview.chromium.org/15738009/diff/9001/LayoutTests/css3/calc/tran...
LayoutTests/css3/calc/transitions-expected.txt:1: PASS - "width" property for
"startCalcEndCalc" element at 0.25s saw something close to: 175
Is it expected to lose the results at 0s?

[commit-bot: I haz the power, 2013-05-23 05:48:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/15738009/13002

[commit-bot: I haz the power, 2013-05-23 06:03:20]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-05-23 06:26:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/15738009/29001

[commit-bot: I haz the power, 2013-05-23 09:28:59]

Change committed as 150976