Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1573753002: Handle invalid hardware output parameters in AudioRendererHost. (Closed)

Created:
4 years, 11 months ago by Guido Urdaneta
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Handle invalid hardware output parameters in AudioRendererHost. It may happen that the audio parameters returned by a hardware device are invalid for Chromium. If the invalidity is caused only by having too many output channels, return the maximum allowed channels to make sure there are no serialization problems. This does not matter in practice, as streams are created using the input channels. BUG=568860 NOTRY=true NOPRESUBMIT=true TBR= Review URL: https://codereview.chromium.org/1542103002 Cr-Commit-Position: refs/heads/master@{#368316} (cherry picked from commit 2d0a4f0bf564bbef1b001004a0d54b9845bc21ad)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -8 lines) Patch
M content/browser/renderer_host/media/audio_renderer_host.cc View 4 chunks +22 lines, -4 lines 0 comments Download
M content/renderer/media/audio_renderer_mixer_manager.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573753002/1
4 years, 11 months ago (2016-01-11 10:29:23 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 11 months ago (2016-01-11 10:29:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573753002/1
4 years, 11 months ago (2016-01-11 10:32:48 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-11 10:32:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573753002/1
4 years, 11 months ago (2016-01-11 10:34:12 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 10:35:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698