Issue 15737018: Fix Object.freeze on dictionary-backed arrays to properly freeze elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15737018: Fix Object.freeze on dictionary-backed arrays to properly freeze elements (Closed)

Created:
7 years, 7 months ago by adamk

Modified:
7 years, 7 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Object.freeze on dictionary-backed arrays to properly freeze elements Follow-up to r14758: slightly rearranges JSObject::Freeze() to avoid duplicating code while still retaining proper dictionary elements storage behavior. Also fix a lint error. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14759

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	src/objects.cc	View		2 chunks	+10 lines, -6 lines	0 comments	Download
	M	test/mjsunit/object-freeze.js	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

7 years, 7 months ago (2013-05-22 20:40:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14759 (presubmit successful).

Expand Messages | Collapse Messages