Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 15737010: add dumpops.lua as a sample scraper that just dumps the arguments (Closed)

Created:
7 years, 7 months ago by reed1
Modified:
7 years, 7 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add dumpops.lua as a sample scraper that just dumps the arguments add SkLua.h for common utilities BUG= R=rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=9242

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+616 lines, -313 lines) Patch
M gyp/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A include/utils/SkLua.h View 1 chunk +52 lines, -0 lines 0 comments Download
A src/utils/SkLua.cpp View 1 chunk +474 lines, -0 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 10 chunks +48 lines, -299 lines 0 comments Download
A tools/lua/dumpops.lua View 1 chunk +34 lines, -0 lines 0 comments Download
M tools/lua/scrape.lua View 3 chunks +5 lines, -13 lines 0 comments Download
M tools/lua/skia.lua View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
7 years, 7 months ago (2013-05-22 15:03:44 UTC) #1
rmistry
LGTM
7 years, 7 months ago (2013-05-22 15:07:27 UTC) #2
reed1
7 years, 7 months ago (2013-05-22 15:13:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r9242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698