Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1573663003: Remove build/c++11 from the set of linter rules ever used. (Closed)

Created:
4 years, 11 months ago by danakj
Modified:
4 years, 11 months ago
Reviewers:
agable, Nico
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, Elliot Glaysher, iannucci+depot_tools_chromium.org, jbroman, Nico, vabr (Chromium)
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove build/c++11 from the set of linter rules ever used. The checks are not reliable for Rvalue references, and only are allowing default/deleted constructors. They are based on the google3 internal rules which do not exactly match our own c++11 rules, and may diverge more over time. Email thread that led to this change here: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/9TZvt8vyeEM R=agable@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298202

Patch Set 1 #

Patch Set 2 : c++11: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M presubmit_canned_checks.py View 1 2 chunks +12 lines, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
danakj
4 years, 11 months ago (2016-01-08 23:40:37 UTC) #1
danakj
Actually I think we should be more aggressive than this. Some PRESUBMITs will override the ...
4 years, 11 months ago (2016-01-08 23:56:49 UTC) #2
danakj
PTAL
4 years, 11 months ago (2016-01-09 00:04:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573663003/20001
4 years, 11 months ago (2016-01-09 00:04:52 UTC) #5
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 11 months ago (2016-01-09 00:04:53 UTC) #7
Nico
non-owner lgtm, thanks! Might want to add a link to the email discussion about this ...
4 years, 11 months ago (2016-01-10 01:21:54 UTC) #11
agable
owner LGTM!
4 years, 11 months ago (2016-01-11 17:56:59 UTC) #12
danakj
On 2016/01/10 01:21:54, Nico wrote: > non-owner lgtm, thanks! > > Might want to add ...
4 years, 11 months ago (2016-01-11 19:33:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573663003/20001
4 years, 11 months ago (2016-01-11 19:33:48 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:37:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298202

Powered by Google App Engine
This is Rietveld 408576698