remove SkImage::applyFilter() -- unused, can always re-add later

remove SkImage::applyFilter() -- unused, can always re-add later

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1573653002

Committed: https://skia.googlesource.com/skia/+/22471ed134f7ad507ce239f96e265f10864adf58

[reed1, 2016-01-08 22:24:34]

Description was changed from

==========
remove SkImage::applyFilter() -- unused, can always re-add later

BUG=skia:
==========

to

==========
remove SkImage::applyFilter() -- unused, can always re-add later

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-08 22:24:45]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 22:24:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573653002/1

[reed1, 2016-01-08 22:25:00]

reed@google.com changed reviewers:
+ robertphillips@google.com, senorblanco@google.com

[commit-bot: I haz the power, 2016-01-08 22:40:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 22:40:55]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2016-01-08 23:56:58]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-01-08 23:56:58]

LGTM.

Could you also remove the sizeConstraint stuff from SkImageFilter?

[reed1, 2016-01-09 01:20:38]

On 2016/01/08 23:56:58, Stephen White wrote:
> LGTM.
> 
> Could you also remove the sizeConstraint stuff from SkImageFilter?

Good idea

[reed1, 2016-01-09 01:20:59]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-01-09 01:21:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573653002/1

[commit-bot: I haz the power, 2016-01-09 01:21:50]

Description was changed from

==========
remove SkImage::applyFilter() -- unused, can always re-add later

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
remove SkImage::applyFilter() -- unused, can always re-add later

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/22471ed134f7ad507ce239f96e265f10864adf58
==========

[commit-bot: I haz the power, 2016-01-09 01:21:51]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/22471ed134f7ad507ce239f96e265f10864adf58

[Noel Gordon, 2016-01-11 04:59:47]

Was was it removed?

[Noel Gordon, 2016-01-11 05:00:09]

Description was changed from

==========
remove SkImage::applyFilter() -- unused, can always re-add later

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/22471ed134f7ad507ce239f96e265f10864adf58
==========

to

==========
remove SkImage::applyFilter() -- unused, can always re-add later

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/22471ed134f7ad507ce239f96e265f10864adf58
==========

[reed1, 2016-01-11 14:25:31]

Never used, and its presence added a fair amount of support complexity elsewhere
in the code.

[Noel Gordon, 2016-01-11 15:57:25]

On 2016/01/11 14:25:31, reed1 wrote:
> Never used, and its presence added a fair amount of support complexity
elsewhere
> in the code.

I see.  I was using it in Blink.  Idea was when drawing a BitmapImage using a
SkColorFilter to apply color correction, there is a srcRect and a dstRect.  I
would apply the SkColorFilter to smaller rectangle to minimize the number of
pixels color corrected.

See https://codereview.chromium.org/1331533002/patch/1080001/1090057 void
BitmapImage::draw(...) where I used ApplyFilter to do that (help minimize the
number of pixels color corrected).

Does that look about right?  I was thinking that when we downscale an image, the
SkColorFilter is applied to the srcRect, but the dstRect is smaller, so it's
faster to if we apply the filter to the dstRect instead.

Is there some other / better way to do it that you could suggest?

[reed1, 2016-01-11 19:30:53]

I think the following is maximally efficient, and can be done via existing apis:

https://fiddle.skia.org/c/b2972e0413e5655174183debd242e009

[Noel Gordon, 2016-01-12 14:01:32]

On 2016/01/11 19:30:53, reed1 wrote:
> I think the following is maximally efficient, and can be done via existing
apis:
> 
> https://fiddle.skia.org/c/b2972e0413e5655174183debd242e009

Thank you.