Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 1573643002: Make trace_event_importer recognize timing conversion and parse web user timing events (Closed)

Created:
4 years, 11 months ago by lpy
Modified:
4 years, 11 months ago
Reviewers:
nduca, fmeawad
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Make trace_event_importer recognize timing conversion and parse web user timing events into nested slices User timing slices are created using Timing.mark(GroupName, TaskName, opt_args), they have the convention of GroupName:TaskName/opt_args where GroupName is used to group slices into a single track with hierarchical structure, opt_args is optional arguments which are parsed into base64 string. For more details, see the design doc: https://docs.google.com/document/d/1-44PszmhQ0-M6Sf2dZpVu-9jAOa7w2_vKAKckRWXJms/edit?usp=sharing BUG=catapult:#1880 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/56ebb1bdfc67d48a5549f012edd56994a0cdbbfc

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Skip create nestable async slices in D8 test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -146 lines) Patch
M tracing/tracing/extras/importer/trace_event_importer.html View 4 chunks +168 lines, -146 lines 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer_test.html View 1 2 3 3 chunks +324 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
lpy
ptal
4 years, 11 months ago (2016-01-08 22:35:34 UTC) #2
nduca
your cl description isn't very clear. i think you should improve it a bit. "Make ...
4 years, 11 months ago (2016-01-11 17:22:18 UTC) #3
lpy
ptal https://codereview.chromium.org/1573643002/diff/20001/tracing/tracing/extras/importer/trace_event_importer_test.html File tracing/tracing/extras/importer/trace_event_importer_test.html (right): https://codereview.chromium.org/1573643002/diff/20001/tracing/tracing/extras/importer/trace_event_importer_test.html#newcode5200 tracing/tracing/extras/importer/trace_event_importer_test.html:5200: On 2016/01/11 17:22:18, nduca wrote: > you probably ...
4 years, 11 months ago (2016-01-11 18:56:40 UTC) #5
nduca
lgtm
4 years, 11 months ago (2016-01-11 19:30:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573643002/40001
4 years, 11 months ago (2016-01-11 21:14:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/1546)
4 years, 11 months ago (2016-01-11 21:24:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573643002/60001
4 years, 11 months ago (2016-01-11 21:34:38 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 21:45:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698