Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 157363007: Fix initializing the compiler parameters before modifying them. (Closed)

Created:
6 years, 10 months ago by nicolascapens
Modified:
6 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix initializing the compiler parameters before modifying them. BUG=342525 R=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gpu/command_buffer/service/shader_translator_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
nicolascapens
PTAL
6 years, 10 months ago (2014-02-13 02:10:17 UTC) #1
Zhenyao Mo
LGTM So the modifying code didn't take effect, and when you fix it, no behavior ...
6 years, 10 months ago (2014-02-13 02:13:24 UTC) #2
nicolascapens
The CQ bit was checked by nicolascapens@chromium.org
6 years, 10 months ago (2014-02-17 15:57:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nicolascapens@chromium.org/157363007/1
6 years, 10 months ago (2014-02-17 15:57:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 17:32:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265365
6 years, 10 months ago (2014-02-17 17:32:20 UTC) #6
nicolascapens
The CQ bit was checked by nicolascapens@chromium.org
6 years, 10 months ago (2014-02-18 15:04:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nicolascapens@chromium.org/157363007/1
6 years, 10 months ago (2014-02-18 15:04:35 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 17:26:23 UTC) #9
Message was sent while issue was closed. 
Change committed as 251786

Powered by Google App Engine
This is Rietveld 408576698