Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1573613002: Skip FlatBuffers tests on dart2js bots. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip FlatBuffers tests on dart2js bots. dart2js does not support Int64. TBR R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d9bf185db49aa99f82c960de877a7c90e38cd78b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
4 years, 11 months ago (2016-01-08 19:39:12 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as d9bf185db49aa99f82c960de877a7c90e38cd78b (presubmit successful).
4 years, 11 months ago (2016-01-08 19:39:21 UTC) #3
sra1
Perhaps it would be better to split the test into two, 64-bit tests and everything ...
4 years, 11 months ago (2016-01-08 19:54:00 UTC) #5
Paul Berry
4 years, 11 months ago (2016-01-08 20:29:23 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698