editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorType.java - Issue 15736020: generate suggestions during analysis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorType.java

Issue 15736020: generate suggestions during analysis (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorSeverity.java ('K') | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorSeverity.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/PubSuggestionCode.java » ('j') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/PubSuggestionCode.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorType.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorType.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorType.java

index 17bd41f74da7858d790dd73e5fad7df2f6126c79..aa408fded5abf1b1f478e00e65b7cf51ec4399ab 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorType.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorType.java

@@ -26,6 +26,12 @@ public enum ErrorType {

COMPILE_TIME_ERROR(ErrorSeverity.ERROR),

/**

+ * Bad practices representing situations where the user has deviated from recommended pub

Brian Wilkerson 2013/05/31 15:28:58 nit: Perhaps "Bad practices representing" --> "Sug

danrubel 2013/05/31 19:43:45 Done.

+ * programming practices.

+ */

+ PUB_SUGGESTION(ErrorSeverity.SUGGESTION),

+ /**

* Static warnings are those warnings reported by the static checker. They have no effect on

* execution. Static warnings must be provided by Dart compilers used during development.