generate suggestions during analysis

editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorSeverity.java

 /*
  * Copyright (c) 2012, the Dart project authors.
  * 
  * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * 
  * http://www.eclipse.org/legal/epl-v10.html
  * 
  * Unless required by applicable law or agreed to in writing, software distributed under the License
  * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
 package com.google.dart.engine.error;
 
 /**
  * Instances of the enumeration {@code ErrorSeverity} represent the severity of an {@link ErrorCode}
  * .
  * 
  * @coverage dart.engine.error
  */
 public enum ErrorSeverity {
   /**
    * The severity representing a non-error. This is never used for any error code, but is useful for
    * clients.
    */
   NONE(" ", "none"),
 
   /**
+   * The severity representing a suggestion. Suggestions are not specified in the Dart language
+   * specification, but provide information about best practices.
+   */
+  SUGGESTION("s", "suggestion"),

[Brian Wilkerson, 2013/05/31 15:28:58]

nit: For consistency, "\"s\"" --> "\"S\""

[danrubel, 2013/05/31 19:43:45]

Done.

+
+  /**
    * The severity representing a warning. Warnings can become errors if the {@code -Werror} command
    * line flag is specified.
    */
   WARNING("W", "warning"),
 
   /**
    * The severity representing an error.
    */
   ERROR("E", "error");
 
@@ skipping 39 matching lines @@
   /**
    * Return the severity constant that represents the greatest severity.
    * 
    * @param severity the severity being compared against
    * @return the most sever of this or the given severity
    */
   public ErrorSeverity max(ErrorSeverity severity) {
     return this.ordinal() >= severity.ordinal() ? this : severity;
   }
 }