Issue 15736017: Issue 1015. Report problem for incompatible right operand and index types.

Issue 15736017: Issue 1015. Report problem for incompatible right operand and index types. (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 1015. Report problem for incompatible right operand and index types. https://code.google.com/p/dart/issues/detail?id=1015 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23076

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -36 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/BinaryExpression.java	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/Expression.java	View	1 chunk	+14 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/IndexExpression.java	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	5 chunks	+58 lines, -30 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	4 chunks	+12 lines, -4 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/15736017/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java (right): https://codereview.chromium.org/15736017/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java#newcode2166 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:2166: StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE); I would prefer to see the test ...

7 years, 7 months ago (2013-05-23 13:18:10 UTC) #3

scheglov

7 years, 7 months ago (2013-05-23 15:57:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r23076 (presubmit successful).

Expand Messages | Collapse Messages