Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/importer/ie_importer_utils_win.cc

Issue 15736014: Registry overriding doesn't seem to work across multiple processes prior to Win8, instead simply ha… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/importer/ie_importer_utils_win.cc
diff --git a/chrome/browser/importer/ie_importer_utils_win.cc b/chrome/browser/importer/ie_importer_utils_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9852773dc3ce64478a1ebd1c0475e1bbe02c2804
--- /dev/null
+++ b/chrome/browser/importer/ie_importer_utils_win.cc
@@ -0,0 +1,26 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/importer/ie_importer_utils_win.h"
+
+#include "chrome/browser/importer/ie_importer_test_registry_overrider_win.h"
+
+namespace {
+
+const char16 kIEFavoritesOrderKey[] =
+ L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\"
+ L"MenuOrder\\Favorites";
+
+}
+
+namespace importer {
+
+base::string16 GetIEFavoritesOrderKey() {
+ // Return kIEFavoritesOrderKey unless an override is on for tests.
robertshield 2013/05/22 20:13:56 nit: is on -> has been set
gab 2013/05/22 20:39:19 Done.
+ base::string16 test_reg_override(
+ IEImporterTestRegistryOverrider::GetTestRegistryOverride());
+ return test_reg_override.empty() ? kIEFavoritesOrderKey : test_reg_override;
+}
+
+}

Powered by Google App Engine
This is Rietveld 408576698