Registry overriding doesn't seem to work across multiple processes prior to Win8, instead simply ha…

chrome/browser/importer/ie_importer_browsertest_win.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The order of these includes is important.
 #include <windows.h>
 #include <unknwn.h>
 #include <intshcut.h>
 #include <shlguid.h>
 #include <urlhist.h>
@@ skipping 13 matching lines @@
 #include "base/string16.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/registry.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/scoped_propvariant.h"
 #include "base/win/windows_version.h"
 #include "chrome/browser/bookmarks/imported_bookmark_entry.h"
 #include "chrome/browser/favicon/imported_favicon_usage.h"
 #include "chrome/browser/importer/ie_importer.h"
+#include "chrome/browser/importer/ie_importer_utils_win.h"
 #include "chrome/browser/importer/ie_importer_test_registry_overrider_win.h"
 #include "chrome/browser/importer/importer_bridge.h"
 #include "chrome/browser/importer/importer_data_types.h"
 #include "chrome/browser/importer/importer_host.h"
 #include "chrome/browser/importer/importer_progress_observer.h"
 #include "chrome/browser/importer/importer_unittest_utils.h"
 #include "chrome/browser/importer/pstore_declarations.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_paths.h"
@@ skipping 36 matching lines @@
   {false, 1, {L"b"}, L"a", "http://www.google.com/1"},
   {false, 1, {L"b"}, L"b", "http://www.google.com/2"},
   {false, 0, {}, L"c", "http://www.google.com/3"},
 };
 
 const char16 kIEIdentifyUrl[] =
     L"http://A79029D6-753E-4e27-B807-3D46AB1545DF.com:8080/path?key=value";
 const char16 kIEIdentifyTitle[] =
     L"Unittest GUID";
 
-const char16 kIEFavoritesOrderKey[] =
-    L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\"
-    L"MenuOrder\\Favorites";
-
 const char16 kFaviconStreamSuffix[] = L"url:favicon:$DATA";
 const char kDummyFaviconImageData[] =
     "\x42\x4D"          // Magic signature 'BM'
     "\x1E\x00\x00\x00"  // File size
     "\x00\x00\x00\x00"  // Reserved
     "\x1A\x00\x00\x00"  // Offset of the pixel data
     "\x0C\x00\x00\x00"  // Header Size
     "\x01\x00\x01\x00"  // Size: 1x1
     "\x01\x00"          // Reserved
     "\x18\x00"          // 24-bits
@@ skipping 36 matching lines @@
     blob.resize(blob.size() + 8);
     uint32 total_size = id_list_size + 8;
     memcpy(&blob[blob.size() - 8], &total_size, 4);
     uint32 sort_index = i;
     memcpy(&blob[blob.size() - 4], &sort_index, 4);
     blob.resize(blob.size() + id_list_size);
     memcpy(&blob[blob.size() - id_list_size], id_list, id_list_size);
     ILFree(id_list_full);
   }
 
-  string16 key_path = kIEFavoritesOrderKey;
+  base::string16 key_path(importer::GetIEFavoritesOrderKey());
   if (!path.empty())
     key_path += L"\\" + path;
   base::win::RegKey key;
   if (key.Create(HKEY_CURRENT_USER, key_path.c_str(), KEY_WRITE) !=
       ERROR_SUCCESS) {
     return false;
   }
   if (key.WriteValue(L"Order", &blob[0], blob.size(), REG_BINARY) !=
       ERROR_SUCCESS) {
     return false;
@@ skipping 247 matching lines @@
 
 }  // namespace
 
 // These tests need to be browser tests in order to be able to run the OOP
 // import (via ExternalProcessImporterHost) which launches a utility process.
 class IEImporterBrowserTest : public InProcessBrowserTest {
  protected:
   virtual void SetUp() OVERRIDE {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
 
-    // Turn the override on for this process and flag child processes that they
-    // should do so as well.
-    ASSERT_TRUE(test_registry_overrider_.SetRegistryOverride());
-
     // This will launch the browser test and thus needs to happen last.
     InProcessBrowserTest::SetUp();
   }
 
   base::ScopedTempDir temp_dir_;
+
+  // Overrides the default registry key for IE's favorites order blob.
   IEImporterTestRegistryOverrider test_registry_overrider_;
 };
 
 IN_PROC_BROWSER_TEST_F(IEImporterBrowserTest, IEImporter) {
   // Sets up a favorites folder.
   base::FilePath path = temp_dir_.path().AppendASCII("Favorites");
   CreateDirectory(path.value().c_str(), NULL);
   CreateDirectory(path.AppendASCII("SubFolder").value().c_str(), NULL);
   base::FilePath links_path = path.AppendASCII("Links");
   CreateDirectory(links_path.value().c_str(), NULL);
@@ skipping 112 matching lines @@
     // number_of_items = 1, size_of_item = 16, size_of_shid is too big.
     {"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"
      "\x01\x00\x00\x00"
      "\x10\x00\x00\x00\x00\x00\x00\x00"
      "\x06\x00\x00\x00" "\x00\x00\x00\x00", 36},
   };
 
   // Verify malformed registry data are safely ignored and alphabetical
   // sort is performed.
   for (size_t i = 0; i < arraysize(kBadBinary); ++i) {
+    base::string16 key_path(importer::GetIEFavoritesOrderKey());
     base::win::RegKey key;
     ASSERT_EQ(ERROR_SUCCESS,
-              key.Create(HKEY_CURRENT_USER, kIEFavoritesOrderKey, KEY_WRITE));
+              key.Create(HKEY_CURRENT_USER, key_path.c_str(), KEY_WRITE));
     ASSERT_EQ(ERROR_SUCCESS,
               key.WriteValue(L"Order", kBadBinary[i].data, kBadBinary[i].length,
                              REG_BINARY));
 
     // Starts to import the above settings.
     // Deletes itself.
     // TODO(gab): Use ExternalProcessImporterHost on Windows.
     ImporterHost* host = new ImporterHost;
     MalformedFavoritesRegistryTestObserver* observer =
         new MalformedFavoritesRegistryTestObserver();
     host->SetObserver(observer);
 
     importer::SourceProfile source_profile;
     source_profile.importer_type = importer::TYPE_IE;
     source_profile.source_path = temp_dir_.path();
 
     host->StartImportSettings(
         source_profile,
         browser()->profile(),
         importer::FAVORITES,
         observer);
     MessageLoop::current()->Run();
   }
 }