Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1573553003: Make our team owners of our tests. (Closed)

Created:
4 years, 11 months ago by Pete Williamson
Modified:
4 years, 11 months ago
Reviewers:
gone, fgorski
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make our team owners of our tests. The offline pages team would like to add unit tests, but nobody on our team is in the OWNERS heirarchy for these files. I think it is reasonable for us to add an owners file with our team. BUG= Committed: https://crrev.com/9c97ebb0f868d7d867445f792bde236b03a9f0d7 Cr-Commit-Position: refs/heads/master@{#368457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A + chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Pete Williamson
Filip - while I am at it, should I add us as owners to EnhancedBookmarks, ...
4 years, 11 months ago (2016-01-08 19:08:29 UTC) #2
gone
lgtm
4 years, 11 months ago (2016-01-08 19:11:10 UTC) #3
fgorski
lgtm
4 years, 11 months ago (2016-01-08 20:45:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573553003/1
4 years, 11 months ago (2016-01-08 21:46:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 23:39:15 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 23:40:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c97ebb0f868d7d867445f792bde236b03a9f0d7
Cr-Commit-Position: refs/heads/master@{#368457}

Powered by Google App Engine
This is Rietveld 408576698