Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 15735005: Collect type feedback for power-of-2 right operands in BinaryOps. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ic.cc » ('j') | src/ic.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1251 matching lines...) Expand 10 before | Expand all | Expand 10 after
1262 Label done, remainder_eq_dividend, slow, both_positive; 1262 Label done, remainder_eq_dividend, slow, both_positive;
1263 Register left_reg = ToRegister(instr->left()); 1263 Register left_reg = ToRegister(instr->left());
1264 Register right_reg = ToRegister(instr->right()); 1264 Register right_reg = ToRegister(instr->right());
1265 Register result_reg = ToRegister(instr->result()); 1265 Register result_reg = ToRegister(instr->result());
1266 1266
1267 ASSERT(left_reg.is(eax)); 1267 ASSERT(left_reg.is(eax));
1268 ASSERT(result_reg.is(edx)); 1268 ASSERT(result_reg.is(edx));
1269 ASSERT(!right_reg.is(eax)); 1269 ASSERT(!right_reg.is(eax));
1270 ASSERT(!right_reg.is(edx)); 1270 ASSERT(!right_reg.is(edx));
1271 1271
1272 Comment(";;; modi has_fixed_right_arg:%d fixed_right_arg_value:%d",
Jakob Kummerow 2013/06/03 09:49:30 This looks like a debugging leftover.
Sven Panne 2013/06/03 12:37:02 Done.
1273 instr->hydrogen()->has_fixed_right_arg(),
1274 instr->hydrogen()->fixed_right_arg_value());
1275
1272 // Check for x % 0. 1276 // Check for x % 0.
1273 if (instr->hydrogen()->CheckFlag(HValue::kCanBeDivByZero)) { 1277 if (instr->hydrogen()->CheckFlag(HValue::kCanBeDivByZero)) {
1274 __ test(right_reg, Operand(right_reg)); 1278 __ test(right_reg, Operand(right_reg));
1275 DeoptimizeIf(zero, instr->environment()); 1279 DeoptimizeIf(zero, instr->environment());
1276 } 1280 }
1277 1281
1278 __ test(left_reg, Operand(left_reg)); 1282 __ test(left_reg, Operand(left_reg));
1279 __ j(zero, &remainder_eq_dividend, Label::kNear); 1283 __ j(zero, &remainder_eq_dividend, Label::kNear);
1280 __ j(sign, &slow, Label::kNear); 1284 __ j(sign, &slow, Label::kNear);
1281 1285
(...skipping 5281 matching lines...) Expand 10 before | Expand all | Expand 10 after
6563 FixedArray::kHeaderSize - kPointerSize)); 6567 FixedArray::kHeaderSize - kPointerSize));
6564 __ bind(&done); 6568 __ bind(&done);
6565 } 6569 }
6566 6570
6567 6571
6568 #undef __ 6572 #undef __
6569 6573
6570 } } // namespace v8::internal 6574 } } // namespace v8::internal
6571 6575
6572 #endif // V8_TARGET_ARCH_IA32 6576 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ic.cc » ('j') | src/ic.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698