Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1573473003: dart2js cps: Do GVN for all primitives except fast constants. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Do GVN for all primitives except fast constants. Previously, trivial primitives such as "x+1" would not be hoisted. Only fast constants are considered trivial now. This is mainly to enable other optimizations. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/7127119f6de49ecd2a4bd8d4dbf70f94e317894b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -36 lines) Patch
M pkg/compiler/lib/src/cps_ir/gvn.dart View 6 chunks +16 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
4 years, 11 months ago (2016-01-08 23:00:50 UTC) #3
Kevin Millikin (Google)
lgtm
4 years, 11 months ago (2016-01-08 23:03:49 UTC) #4
asgerf
4 years, 11 months ago (2016-01-08 23:38:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7127119f6de49ecd2a4bd8d4dbf70f94e317894b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698