third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp - Issue 1573423002: CSS Custom Properties fail when defined in specific order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

Issue 1573423002: CSS Custom Properties fail when defined in specific order (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding testcase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

index 73284bf71042a3feca3f3e5c0340713d066add62..11af23ec01c730672c747f9248ffecb5f7aa64d0 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

@@ -55,7 +55,7 @@ void CSSVariableResolver::resolveVariableTokensRecursive(CSSParserTokenRange ran

Vector<CSSParserToken> tokens;

if (variableData->needsVariableResolution()) {

m_variablesSeen.add(variableName);

- resolveVariableReferencesFromTokens(variableData->tokens(), result, context);

+ resolveVariableReferencesFromTokens(variableData->tokens(), tokens, context);

m_variablesSeen.remove(variableName);

// The old variable data holds onto the backing string the new resolved CSSVariableData

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/variables/variable-resolution-order-independent.html ('k') | no next file » | no next file with comments »