Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1573423002: CSS Custom Properties fail when defined in specific order (Closed)

Created:
4 years, 11 months ago by ramya.v
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh, shans
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Custom Properties fail when defined in specific order When variable needs resolution, during calculation tokens are not properly updated because of which resolution is failing. Updated the same. BUG=570316 Committed: https://crrev.com/507fedb1a47c87343369c68eba5373856ac755ee Cr-Commit-Position: refs/heads/master@{#369111}

Patch Set 1 #

Patch Set 2 : Adding testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/variables/variable-resolution-order-independent.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
ramya.v
PTAL! Thanks
4 years, 11 months ago (2016-01-12 06:22:40 UTC) #2
Timothy Loh
4 years, 11 months ago (2016-01-12 06:26:38 UTC) #4
shans
On 2016/01/12 at 06:26:38, timloh wrote: > This looks right to me. Let's just check ...
4 years, 11 months ago (2016-01-12 10:38:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573423002/20001
4 years, 11 months ago (2016-01-13 03:11:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/134858)
4 years, 11 months ago (2016-01-13 03:21:04 UTC) #9
Timothy Loh
On 2016/01/13 03:21:04, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-13 03:50:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573423002/20001
4 years, 11 months ago (2016-01-13 04:23:36 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-13 04:42:35 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 04:44:00 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/507fedb1a47c87343369c68eba5373856ac755ee
Cr-Commit-Position: refs/heads/master@{#369111}

Powered by Google App Engine
This is Rietveld 408576698