Add switch to asm to wasm

Add switch to asm to wasm

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@google.com
BUG=

Committed: https://crrev.com/210e65ed12399b81c87cab0503b904d94869bec2
Cr-Commit-Position: refs/heads/master@{#33220}

[aseemgarg, 2016-01-12 00:49:42]

Please review

[bradnelson, 2016-01-12 01:06:42]

bradnelson@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bradnelson, 2016-01-12 01:06:43]

lgtm

https://codereview.chromium.org/1573413002/diff/40001/src/wasm/asm-wasm-build...
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1573413002/diff/40001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:152: DCHECK(stmt->target() != NULL);
Is this actually guaranteed?

https://codereview.chromium.org/1573413002/diff/40001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:239: BlockVisitor visitor(this,
stmt->AsBreakableStatement(), kExprBlock, false);
I wonder if folding the block_size_ = 0 into the visitor would be more clear.
Everywhere else either does this or sets it explicitly to a count based on what
follows, which amounts to the same thing. (No need in this change).

[aseemgarg, 2016-01-12 01:38:37]

https://codereview.chromium.org/1573413002/diff/40001/src/wasm/asm-wasm-build...
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1573413002/diff/40001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:152: DCHECK(stmt->target() != NULL);
On 2016/01/12 01:06:43, bradnelson wrote:
> Is this actually guaranteed?

yes

https://codereview.chromium.org/1573413002/diff/40001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:239: BlockVisitor visitor(this,
stmt->AsBreakableStatement(), kExprBlock, false);
On 2016/01/12 01:06:43, bradnelson wrote:
> I wonder if folding the block_size_ = 0 into the visitor would be more clear.
> Everywhere else either does this or sets it explicitly to a count based on
what
> follows, which amounts to the same thing. (No need in this change).

Will take care in next commit

[aseemgarg, 2016-01-12 01:38:45]

The CQ bit was checked by aseemgarg@chromium.org

[commit-bot: I haz the power, 2016-01-12 01:38:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573413002/40001

[commit-bot: I haz the power, 2016-01-12 02:02:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 02:02:59]

Description was changed from

==========
Add switch to asm to wasm

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@google.com
BUG=
==========

to

==========
Add switch to asm to wasm

TEST=asm-wasm.js
R=titzer@chromium.org,bradnelson@google.com
BUG=

Committed: https://crrev.com/210e65ed12399b81c87cab0503b904d94869bec2
Cr-Commit-Position: refs/heads/master@{#33220}
==========

[commit-bot: I haz the power, 2016-01-12 02:02:59]

Patchset 3 (id:??) landed as
https://crrev.com/210e65ed12399b81c87cab0503b904d94869bec2
Cr-Commit-Position: refs/heads/master@{#33220}