Source/core/css/CSSParser.cpp - Issue 15734030: Remove support for device-width|height for @viewport rule according to spec change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSParser.cpp

Issue 15734030: Remove support for device-width|height for @viewport rule according to spec change (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Removed comment Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/chromium-win/css3/device-adapt/viewport-properties-validation-expected.txt ('k') | Source/core/css/CSSValueKeywords.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSParser.cpp

diff --git a/Source/core/css/CSSParser.cpp b/Source/core/css/CSSParser.cpp

index fb1074f923083f5b7721b3458f151dad63a6ae5b..a9f57995b77fbc53116662a484d8e19dc342778e 100644

--- a/Source/core/css/CSSParser.cpp

+++ b/Source/core/css/CSSParser.cpp

@@ -11470,11 +11470,11 @@ bool CSSParser::parseViewportProperty(CSSPropertyID propId, bool important)

bool validPrimitive = false;

switch (propId) {

- case CSSPropertyMinWidth: // auto | device-width | device-height | <length> | <percentage>

+ case CSSPropertyMinWidth: // auto | <length> | <percentage>

case CSSPropertyMaxWidth:

case CSSPropertyMinHeight:

case CSSPropertyMaxHeight:

- if (id == CSSValueAuto || id == CSSValueDeviceWidth || id == CSSValueDeviceHeight)

+ if (id == CSSValueAuto)

validPrimitive = true;

else

validPrimitive = (!id && validUnit(value, FLength | FPercent | FNonNeg));