Issue 15734007: Move global pretenuring flag check to ShouldGloballyPretenure().

Issue 15734007: Move global pretenuring flag check to ShouldGloballyPretenure(). (Closed)

Created:
7 years, 7 months ago by Hannes Payer (out of office)

Modified:
7 years, 7 months ago

Reviewers:
mvstanton, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move global pretenuring flag check to ShouldGloballyPretenure(). BUG= Committed: https://code.google.com/p/v8/source/detail?r=14763

Patch Set 5 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -12 lines)			Patch
M	src/code-stubs-hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View	1 2 3 4	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/hydrogen.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/15734007/diff/7001/src/heap.h File src/heap.h (right): https://codereview.chromium.org/15734007/diff/7001/src/heap.h#newcode1552 src/heap.h:1552: void SetNewSpaceHighPromotionModeActive(bool mode) { nit: ...

7 years, 7 months ago (2013-05-23 08:05:28 UTC) #3

Hannes Payer (out of office)

Committed patchset #5 manually as r14763 (presubmit successful).

7 years, 7 months ago (2013-05-23 08:17:10 UTC) #4

Hannes Payer (out of office)

7 years, 7 months ago (2013-05-23 08:54:52 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/15734007/diff/7001/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/15734007/diff/7001/src/heap.h#newcode1552
src/heap.h:1552: void SetNewSpaceHighPromotionModeActive(bool mode) {
On 2013/05/23 08:05:28, Michael Starzinger wrote:
> nit: Can we add a short one-liner comment here saying that "// This is only
> needed for tests to high promotion mode."

Done.

Expand Messages | Collapse Messages