Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6678)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 15734006: Restructure user-creation flow and surface errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
===================================================================
--- chrome/browser/resources/options/browser_options.js (revision 202001)
+++ chrome/browser/resources/options/browser_options.js (working copy)
@@ -1050,6 +1050,24 @@
},
/**
+ * Reports a local error (e.g., disk full) to the "create" overlay during
+ * profile creation.
+ * @private
+ */
+ showCreateProfileLocalError_: function() {
+ CreateProfileOverlay.onLocalError();
+ },
+
+ /**
+ * Reports successful profile creation to the "create" overlay.
+ * @param {boolean} is_limited True if the new profile is for a limited user.
+ * @private
+ */
+ showCreateProfileSuccess_: function(is_limited) {
Andrew T Wilson (Slow) 2013/05/27 12:02:43 nit: should be isLimited, I think?
Pam (message me for reviews) 2013/05/27 14:34:37 Argh, a pox on whoever made the conventions differ
+ CreateProfileOverlay.onSuccess(is_limited);
+ },
+
+ /**
* Returns the currently active profile for this browser window.
* @return {Object} A profile info object.
* @private
@@ -1429,6 +1447,8 @@
'setupPageZoomSelector',
'setupProxySettingsSection',
'showBluetoothSettings',
+ 'showCreateProfileLocalError',
+ 'showCreateProfileSuccess',
'showMouseControls',
'showTouchpadControls',
'updateAccountPicture',

Powered by Google App Engine
This is Rietveld 408576698