Restructure user-creation flow and surface errors

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 1032 matching lines @@
           !$('manage-profile-overlay-manage').hidden) {
         ManageProfileOverlay.showManageDialog();
       } else {
         ManageProfileOverlay.getInstance().visible = false;
       }
 
       this.setProfileViewButtonsStatus_();
     },
 
     /**
+     * Reports a local error (e.g., disk full) to the "create" overlay during
+     * profile creation.
+     * @private
+     */
+    showCreateProfileLocalError_: function() {
+      CreateProfileOverlay.onLocalError();
+    },
+
+    /**
+    * Reports successful profile creation to the "create" overlay.
+    * @param {boolean} is_limited True if the new profile is for a limited user.
+    * @private
+    */
+    showCreateProfileSuccess_: function(is_limited) {

[Andrew T Wilson (Slow), 2013/05/27 12:02:43]

nit: should be isLimited, I think?

[Pam (message me for reviews), 2013/05/27 14:34:37]

Argh, a pox on whoever made the conventions different for C++ and JS. But only a
minor pox, maybe canarypox or chickenpox: not smallpox or anything.

+      CreateProfileOverlay.onSuccess(is_limited);
+    },
+
+    /**
      * Returns the currently active profile for this browser window.
      * @return {Object} A profile info object.
      * @private
      */
     getCurrentProfile_: function() {
       for (var i = 0; i < $('profiles-list').dataModel.length; i++) {
         var profile = $('profiles-list').dataModel.item(i);
         if (profile.isCurrentProfile)
           return profile;
       }
@@ skipping 359 matching lines @@
     'setMetricsReportingSettingVisibility',
     'setPasswordGenerationSettingVisibility',
     'setProfilesInfo',
     'setSpokenFeedbackCheckboxState',
     'setThemesResetButtonEnabled',
     'setVirtualKeyboardCheckboxState',
     'setupCloudPrintConnectorSection',
     'setupPageZoomSelector',
     'setupProxySettingsSection',
     'showBluetoothSettings',
+    'showCreateProfileLocalError',
+    'showCreateProfileSuccess',
     'showMouseControls',
     'showTouchpadControls',
     'updateAccountPicture',
     'updateAutoLaunchState',
     'updateDefaultBrowserState',
     'updateInstantCheckboxState',
     'updateSearchEngines',
     'updateStartupPages',
     'updateSyncState',
   ].forEach(function(name) {
@@ skipping 12 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });