Restructure user-creation flow and surface errors

Restructure user-creation flow for modularity and error-reporting.

Pulls the call to open a new user's first window out of the ProfileManager and
into the UI layer that called for the creation of the new user. This improves
code layering (ProfileManager shouldn't have to know about the host desktop type)
and allows us to communicate errors during user creation (also
partially added here, although most errors aren't yet captured).

BUG=153864, 243379
TEST=existing unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202939

[Pam (message me for reviews), 2013-05-24 14:07:32]

sail - profiles
jhawkins - webui and resources
atwilson - sync

In addition to the stated goals of this patch, it also begins to add support
stubs for some of the things we'll need for creating limited users, namely error
reporting and a confirmation step.

Thanks!
- Pam

[sail, 2013-05-24 22:22:33]

Look really good. profiles/* LGTM

[Pam (message me for reviews), 2013-05-27 08:17:25]

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
File chrome/browser/resources/options/manage_profile_overlay.js (right):

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
chrome/browser/resources/options/manage_profile_overlay.js:469: onSuccess_:
function(is_managed) {
I will change this to isManaged before committing.

[Andrew T Wilson (Slow), 2013-05-27 12:02:43]

LGTM with a few nits

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
chrome/browser/resources/options/browser_options.js:1066:
showCreateProfileSuccess_: function(is_limited) {
nit: should be isLimited, I think?

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
File chrome/browser/resources/options/manage_profile_overlay.js (right):

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
chrome/browser/resources/options/manage_profile_overlay.js:52: // until we
finish creating the profile.
Do we need to guard against multiple clicks by disabling the button, if we
aren't closing the overlay?

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
chrome/browser/resources/options/manage_profile_overlay.js:238: *     'manage').
document new parameter.

[Pam (message me for reviews), 2013-05-27 14:34:36]

Thanks! James, ready when you are. :)

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
chrome/browser/resources/options/browser_options.js:1066:
showCreateProfileSuccess_: function(is_limited) {
On 2013/05/27 12:02:43, Andrew T Wilson wrote:
> nit: should be isLimited, I think?

Argh, a pox on whoever made the conventions different for C++ and JS. But only a
minor pox, maybe canarypox or chickenpox: not smallpox or anything.

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
File chrome/browser/resources/options/manage_profile_overlay.js (right):

https://codereview.chromium.org/15734006/diff/15003/chrome/browser/resources/...
chrome/browser/resources/options/manage_profile_overlay.js:52: // until we
finish creating the profile.
On 2013/05/27 12:02:43, Andrew T Wilson wrote:
> Do we need to guard against multiple clicks by disabling the button, if we
> aren't closing the overlay?

I'd been pondering that. I don't think there's actually a technical problem with
queueing up multiple creates, but I'm not sure it's the better UX, and there's a
bit of awkwardness in avoiding duplicate names. For now, I'll disable the
button.

[Pam (message me for reviews), 2013-05-29 17:19:31]

James, please take a look. This patch includes a fix for that failing Mac
browser_test.

[James Hawkins, 2013-05-29 17:22:44]

LGTM with nit.

https://codereview.chromium.org/15734006/diff/104001/chrome/browser/resources...
File chrome/browser/resources/options/manage_profile_overlay.js (right):

https://codereview.chromium.org/15734006/diff/104001/chrome/browser/resources...
chrome/browser/resources/options/manage_profile_overlay.js:479:
console.log('Success - show confirmation');
nit: Remove the log.

[commit-bot: I haz the power, 2013-05-29 17:32:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/15734006/118001

[commit-bot: I haz the power, 2013-05-29 19:43:15]

Change committed as 202939